Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rasa data validate for rules containing default actions as active_loop #11193

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Fix rasa data validate for rules containing default actions as active_loop #11193

merged 3 commits into from
Jun 16, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Jun 15, 2022 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita linked an issue Jun 15, 2022 that may be closed by this pull request
rasa data validate causes error with "action_two_stage_fallback" #10430
Closed
@ancalita ancalita requested review from indam23 and m-vdb June 15, 2022 09:49
@ancalita ancalita marked this pull request as ready for review June 15, 2022 09:49
@ancalita ancalita requested a review from a team as a code owner June 15, 2022 09:49
@m-vdb m-vdb requested review from losterloh and removed request for m-vdb June 15, 2022 09:54
losterloh
losterloh suggested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@losterloh losterloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the test that was added does not actually test the bug / changed behavior, since the test runs green when the change in validator.py is reverted.

@ancalita
Copy link
Member Author

@losterloh Good catch! For some reason, the rule that I add is not detected: it gets transformed in a StoryGraph with 0 steps, which is why the test runs green since the whole for loop in the verify method gets bypassed. I'll investigate further 👍🏼

@ancalita ancalita requested a review from losterloh June 15, 2022 12:15
@ancalita
Copy link
Member Author

ancalita commented Jun 15, 2022 •
edited
Loading

the test that was added does not actually test the bug / changed behavior, since the test runs green when the change in validator.py is reverted.

@losterloh Found the culprit - I was modifying by mistake the string parameter file_name to a Path, then the importer didn't recognise the file as a stories/rules file and therefore initialised a StoryGraph with 0 steps. Fixed now, if you revert the change and run the test, it fails.

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11193--rasahq-docs-rasa-v2.netlify.app/docs/rasa

losterloh
losterloh approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@losterloh losterloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 💯

@ancalita ancalita merged commit d29af4a into 3.2.x Jun 16, 2022
@ancalita ancalita deleted the ATO-151-data-validation-fails-in-rasa-3-x-because-of-action-two-stage-fallback branch June 16, 2022 17:32
ancalita added a commit that referenced this pull request Jun 17, 2022
@rasabot @sanchariGr
@m-vdb @ancalita
Merge 3.2.x into main (#11195)
5eade0b 
* bump rasa-sdk dependency

* prepared release of version 3.2.0

* Modify spacy version

* Empty-Commit

* Fix `rasa data validate` for rules containing default actions as `active_loop` (#11193)

* add fix and unit test

* add changelog entry

* amend local variable name in unit test

* poetry update

Co-authored-by: sanchariGr <[email protected]>
Co-authored-by: Maxime Vdb <[email protected]>
Co-authored-by: Anca Lita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losterloh losterloh losterloh approved these changes

@indam23 indam23 indam23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rasa data validate causes error with "action_two_stage_fallback"
3 participants
@ancalita @losterloh @indam23