Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix JSON to YAML conversion #10991

Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix: fix JSON to YAML conversion #10991

merged 1 commit into from
Mar 15, 2022

Conversation

wochinge
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from ancalita March 14, 2022 18:07
@wochinge wochinge marked this pull request as ready for review March 14, 2022 18:07
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@wochinge wochinge merged commit 1841593 into 3.0.x Mar 15, 2022
@wochinge wochinge deleted the fix-json-to-yaml-convert branch March 15, 2022 09:58
wochinge added a commit that referenced this pull request Mar 15, 2022
wochinge added a commit that referenced this pull request Mar 15, 2022
@m-vdb m-vdb mentioned this pull request May 13, 2022
4 tasks
indam23 pushed a commit that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants