Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct transformer_size parameter if needed for ResponseSelector during loading #10646

Closed
wants to merge 8 commits into from
Closed

Correct transformer_size parameter if needed for ResponseSelector during loading #10646

wants to merge 8 commits into from

Conversation

jupyterjazz
Copy link
Contributor

@jupyterjazz jupyterjazz commented Jan 7, 2022 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@jupyterjazz jupyterjazz requested a review from a team as a code owner January 7, 2022 15:43
@jupyterjazz jupyterjazz requested review from a team, ancalita and kedz and removed request for a team January 7, 2022 15:43
@jupyterjazz jupyterjazz changed the title Set default transformer size for ResponseSelector if needed after loading Set default transformer size if needed for ResponseSelector after loading Jan 7, 2022
@jupyterjazz jupyterjazz changed the title Set default transformer size if needed for ResponseSelector after loading Correct default transformer size if needed for ResponseSelector after loading Jan 7, 2022
@jupyterjazz jupyterjazz changed the title Correct default transformer size if needed for ResponseSelector after loading Correct transformer_size parameter if needed for ResponseSelector after loading Jan 7, 2022
@jupyterjazz jupyterjazz changed the title Correct transformer_size parameter if needed for ResponseSelector after loading Correct transformer_size parameter if needed for ResponseSelector during loading Jan 7, 2022
ancalita
ancalita reviewed Jan 7, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 However since it's a bugfix, shouldn't this PR target 3.0.x?

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

🚀 A preview of the docs have been deployed at the following URL: https://10646--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@jupyterjazz
Copy link
Contributor Author

LGTM rocket However since it's a bugfix, shouldn't this PR target 3.0.x?

@ancalita good point. I'll open a new one.

@jupyterjazz jupyterjazz closed this Jan 7, 2022
@jupyterjazz jupyterjazz deleted the bug/10519 branch January 11, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita left review comments

@kedz kedz Awaiting requested review from kedz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jupyterjazz @ancalita