Make RASA_ENVIRONMENT available in events logged by Kafka producer
#10413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indam23
requested review from
a team and
aeshky
and removed request for
a team
indam23
requested review from
b-quachtran and
joejuzl
and removed request for
a team and
aeshky
joejuzl
reviewed
Nov 29, 2021
rasa/core/brokers/kafka.py
Outdated
| @@ -198,7 +200,16 @@ def _publish(self, event: Dict[Text, Any]) -> None: | |||
| logger.debug( | |||
| f"Calling kafka send({self.topic}, value={event}, key={partition_key!s})" | |||
| ) | |||
| self.producer.send(self.topic, value=event, key=partition_key) | |||
|
|
|||
| headers = [("RASA_ENVIRONMENT", bytes(self.rasa_environment, encoding=DEFAULT_ENCODING))] | |||
There was a problem hiding this comment.
Can we have a unit test for this?
There was a problem hiding this comment.
Trying to figure out how to check this because it's not a property like it is for Pika - it only shows up in the headers when the event is sent. Is it necessary to mock a consumer to check what is sent, or do you think it can be mocked higher up?
There was a problem hiding this comment.
If it requires everything to be mocked then probably not worth it. We really need some integration tests using an actual kafka.
There was a problem hiding this comment.
Gotcha. So no unit tests on this PR then? All we can assert without mocks is that the environment var is fetched but that seems a little ¯_(ツ)_/¯
joejuzl
approved these changes
Nov 29, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
RASA_ENVIRONMENTheader to the Kafka event producer to make it available to consumers as is done in theapp_idfor PikaStatus (please check what you already did):
black(please check Readme for instructions)