Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing type annotations #10091

Merged
merged 1 commit into from
Nov 5, 2021
Merged

add missing type annotations #10091

merged 1 commit into from
Nov 5, 2021

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Nov 5, 2021

Proposed changes:

  • fix sanic typing issues
  • renable no-untyped-call

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from m-vdb November 5, 2021 13:06
m-vdb
m-vdb approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot woot that was fast, thanks @wochinge 🚀

Base automatically changed from sanic-update to main November 5, 2021 13:39
@joejuzl joejuzl merged commit 456f34a into main Nov 5, 2021
@joejuzl joejuzl deleted the sanic-type-fixes branch November 5, 2021 13:44
srinivasupadhya pushed a commit to srinivasupadhya/rasa that referenced this pull request Nov 8, 2021
@wochinge @srinivasgoto
add missing type annotations (RasaHQ#10091)
dd794fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @m-vdb @joejuzl