Type error in facebook.py

[wavymazy]

Hi,

I tried deploying the bot with Facebook and one error appears when I start a form:

TypeError: pop() takes at most 1 argument (2 given) (in rasa/core/channels/facebook.py : line 229).

I did a workaround but I thought you guys might want to take a look at this.

Cheers.

[sara-tagger]

Thanks for raising this issue, @tabergma will get back to you about it soon✨

Please also check out the docs and the forum in case your issue was raised there too 🤗

[tabergma]

Thanks for raising the issue @wavymazy. What is your current workaround?

[wavymazy]

Hello,

Since the issue was that .pop("sender", {}) is expecting the json to be a dict, I just put in place a check to handle the case when it's a list.

async def send_custom_json(
    self, recipient_id: Text, json_message: Dict[Text, Any], **kwargs: Any
) -> None:
    """Sends custom json data to the output."""

    if isinstance(json_message, list):
        if isinstance(json_message.pop(), list):
            recipient_id = json_message.pop().pop() or recipient_id
        else:
            recipient_id = json_message.pop().pop("id", None) or recipient_id
    else:
        if isinstance(json_message.pop("sender", {}), list):
            recipient_id = json_message.pop("sender", {}).pop("id") or recipient_id
        else:
            recipient_id = json_message.pop("sender", {}).pop("id", None) or recipient_id

    self.messenger_client.send(json_message, recipient_id, "RESPONSE")

[tabergma]

Great! As you already have a solution, do you want to contribute and create a PR?

[silvasara]

I am interested in working on this issue, is it still valid?

[tabergma]

@silvasara I think it is. Feel free to pick it up 🚀

[jppgomes]

Hello, I checked the missing tests for the correction, can I implement and send the pr? @tabergma

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ErickGiffoni]

Is this issue still a problem ?
I am with a group of developers here that might want to solve it !

[ancalita]

Solved by #9692 PR