Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port build of multi-platform dev docker images from 3.9.x to main #1125

Merged
merged 10 commits into from
Jul 11, 2024

Conversation

radovanZRasa
Copy link
Contributor

Port a fix for multi-platform dev docker images from 3.9.x branch onto main.

Ported changes

Rearrange build of Docker images in GitHub workflows for easier management.
Add new workflow to build image when code is merged to main
Build Docker dev image with pr### (ex. pr1234) tag on pull requests, devs should use this image if they need it in rasa
Move build of Docker images and PyPi package when tag is pushed to a new workflow
Add separate workflow to cleanup dev docker image created with pr### tag when pull request is merged. Devs who are working on rasa should switch to the latest image once PR on rasa-sdk is merged.

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@radovanZRasa radovanZRasa requested a review from a team as a code owner July 10, 2024 15:47
@radovanZRasa radovanZRasa requested review from aerowithanl and sanchariGr and removed request for a team July 10, 2024 15:47
Copy link
Collaborator

@sanchariGr sanchariGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@radovanZRasa radovanZRasa force-pushed the port/push-PR-dev-docker-images branch from 158a083 to e8d6e77 Compare July 11, 2024 11:32
@radovanZRasa radovanZRasa merged commit 6423418 into main Jul 11, 2024
14 checks passed
@radovanZRasa radovanZRasa deleted the port/push-PR-dev-docker-images branch July 11, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants