Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Sanic 22.12LTS #1103

Merged
merged 12 commits into from
Jun 4, 2024
Merged

Upgrade to Sanic 22.12LTS #1103

merged 12 commits into from
Jun 4, 2024

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented May 14, 2024 •
edited by jira bot
Loading

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review June 3, 2024 14:10
@ancalita ancalita changed the title Investigate Sanic upgrade Upgrade to Sanic 22.12LTS Jun 3, 2024
Tawakalt
Tawakalt approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Tawakalt Tawakalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Dropped a small comment too.

tests/test_actions/test_actions.py Outdated Show resolved Hide resolved
@ancalita ancalita merged commit 2dd8011 into main Jun 4, 2024
16 checks passed
@ancalita ancalita deleted the ATO-2400-sdk-sanic-upgrade-investigation branch June 4, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tawakalt Tawakalt Tawakalt approved these changes

@radovanZRasa radovanZRasa radovanZRasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ancalita @Tawakalt @radovanZRasa