Update prompt-toolkit, ruff, opentelemetry-exporter-jaeger #1051
Conversation
tabergma
changed the title
tabergma
changed the title
|
Should this PR target |
| @@ -79,13 +79,13 @@ coloredlogs = ">=10,<16" | |||
| sanic = "^21.12.0" | |||
| typing-extensions = ">=4.1.1,<5.0.0" | |||
| Sanic-Cors = "^2.0.0" | |||
| prompt-toolkit = "^3.0,<3.0.29" | |||
There was a problem hiding this comment.
This update has to be validated with rasa-private CLI commands (like rasa interactive or rasa shell), because they had introduced a breaking change in 3.0.30 which I'm not sure they addressed.
| "ruamel.yaml" = ">=0.16.5,<0.18.0" | ||
| websockets = ">=10.0,<12.0" | ||
| pluggy = "^1.0.0" | ||
| opentelemetry-api = "~1.15.0" | ||
| opentelemetry-sdk = "~1.15.0" | ||
| opentelemetry-exporter-jaeger = "~1.15.0" |
There was a problem hiding this comment.
Two points here, if we're updating this dependency, all the other open telemetry dependencies have to be on the same minor. In addition, we have to align this dependency version with the identical dependencies in rasa-plus.
There was a problem hiding this comment.
Thanks @ancalita for pointing it out. As it seems to be much more work than expected, I would close this PR and create an issue for it. We are currently focusing on a project that needs to be done by end of the year.
Housekeeping PRs should always target |
|
As there is much more work than expected, we will tackle it later (https://rasahq.atlassian.net/browse/ENG-718) |
Proposed changes:
Update
Status (please check what you already did):
black(please check Readme for instructions)