Preparation for PySide6 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re aren't any items. Fixes: RareDevs#413 (comment)
`entitlements` might be an empty list, so check if it is truthy instead of `None`
PySide6 complains that the signals have already been deleted
This pattern caused PySide6 to derp hard. Use abstract methods instead.
The hacky way used in AppNameCompleter doesn't work in PySide6, so search for the app_name based on the completed game's title.
In PySide6 setting the button as the button in the tab causes a crash, so work around that.
This should be properly solved in the future by refactoring MoveDialog
For an unknown reason presently, the eventFilter is called with a QRunnable as the second argument instead of a QEvent. This causes a crash because a QRunnable doesn't have a `type` attribute. The target object seems to be the launch button. Work-around it by filtering out the event early if the second argument is not a QEevent instance and log an error.
Kyle2142
reviewed
Jul 6, 2024
| license="GPL-3", | ||
| description="A gui for Legendary", | ||
| description="A gui for legendary", |
There was a problem hiding this comment.
What's up with lowercasing these strings? They were correct as they were
There was a problem hiding this comment.
The capitalization was inconsistent between files. gui should also be GUI technically but looks ugly as a window title. I'd like to find some other descriptive text for Rare anyways, as both GUI and Legendary are not descriptive enough for unfamiliar users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.