Refactor the Store page #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone wants to test and tell me their experience before merging this, I would be very thankful |
loathingKernel
force-pushed
the
shop_refactor
branch
2 times, most recently
from
dfc046f to
5ae9e6f
Compare
Important changes: * Refactored QtRequests to accept parameters for `GET` operations * Infer response data type from content-type header * Support caching to disk, a manager with this set prefers the cache * Support multiple handlers for a single request (unused, possibly pointeless) * Subclass `ShopImageWidget` for all widgets used in the shop * Request a resized image instead of the original one * Fix the search and browse functions
* Add a big back button in details page. * Add static CSS to render QPushButtons as flat when the `flat` property is set * Remove outer scroll areas from details page since the page is already adjustable * Remove scroll area from the requirements widget because ElideLabels are already used in it. * Fix crash when sorting the wishlist
* Use horizontal scrollarea for free games. Based on the same idea as WrapperSettings scrollarea. Both need some adjustments. * Remove debugging dialogs. Need a better way anyways to debug.
* Move filter combobox at the beginning of the top panel and move the order combobox after it to replicate the order in the library view.
loathingKernel
force-pushed
the
shop_refactor
branch
from
2fc729c to
14bde0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still a lot of work to be done, especially in improving the GraphQL API integration, fixing games that depend on it, and re-implementing Search. On the other hand, this should be enough of a skeleton to improve upon gradually.