Merge pull request #427 from loathingKernel/develop

Do not quote executable path for steam shortcuts on Windows
RareDevs · Jul 23, 2024 · 219d2e1 · 219d2e1
2 parents 8f456e0 + 715ce73
commit 219d2e1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/rare/commands/launcher/__init__.py b/rare/commands/launcher/__init__.py
@@ -153,9 +153,10 @@ def __init__(self, args: InitArgs):
         language = self.settings.value(*options.language)
         self.load_translator(language)
 
-        if QSettings(self).value(*options.log_games) or (
-            game.app_name in DETACHED_APP_NAMES and platform.system() == "Windows"
-        ):
+        # if QSettings(self).value(*options.log_games) or (
+        #     game.app_name in DETACHED_APP_NAMES and platform.system() == "Windows"
+        # ):
+        if QSettings(self).value(*options.log_games):
             self.console = ConsoleDialog(game.app_title)
             self.console.show()
 

diff --git a/rare/models/steam.py b/rare/models/steam.py
@@ -1,3 +1,4 @@
+import platform
 import binascii
 import shlex
 from dataclasses import dataclass, field
@@ -108,7 +109,7 @@ def create(
         shortcut = cls.from_dict({})
         shortcut.appid = cls.calculate_appid(app_name)
         shortcut.AppName = app_title
-        shortcut.Exe = executable
+        shortcut.Exe = executable if platform.system() == "Windows" else shlex.quote(executable)
         shortcut.StartDir = start_dir
         shortcut.icon = icon
         shortcut.LaunchOptions = shlex.join(launch_options)