Update interface and integration tests #5
Conversation
Makuh17
left a comment
Makuh17
left a comment
There was a problem hiding this comment.
I dont really understand a lot of what is going on, but looks fine to me
| result = self.get_status() | ||
| if result.state == "Completed": | ||
| break | ||
| wait_time *= 2 |
There was a problem hiding this comment.
Is this to exponentially wait more and more? Is that smart? I guess it is fine
There was a problem hiding this comment.
yeah that's what it is supposed to do for now. Maybe it should be capped to a maximum of once every 10 minutes or so ^^
| :rtype: dict | ||
| """ | ||
| # return self.openapi_service.order_api.order_get_order_results_get(self.order_id) # throws error | ||
| raise NotImplementedError("Currently not supported") |
| order_model = CreateOrderModel( | ||
| orderName=self._name, | ||
| workflow=CreateOrderModelWorkflow(self._workflow.to_model()), | ||
| userFilters=[], | ||
| referee=CreateOrderModelReferee(self._referee.to_model()), | ||
| ) | ||
|
|
||
| result = self._openapi_service.order_api.order_create_post( | ||
| create_order_model=order_model | ||
| ) | ||
|
|
||
| self.order_id = result.order_id | ||
| self._dataset = RapidataDataset(result.dataset_id, self._openapi_service) | ||
| order = RapidataOrder(order_id=self.order_id, dataset=self._dataset, openapi_service=self._openapi_service) |
There was a problem hiding this comment.
Why did this get much more involved?
There was a problem hiding this comment.
this got moved from the RapidataOrder class, since this now requires the OrderID to be present
| def k_factor(self, k_factor: int): | ||
| self._k_factor = k_factor | ||
| return self | ||
|
|
||
| def match_size(self, match_size: int): | ||
| self._match_size = match_size | ||
| return self | ||
|
|
||
| def matches_until_completed(self, matches_until_completed: int): | ||
| self._matches_until_completed = matches_until_completed | ||
| return self |
There was a problem hiding this comment.
So now these are not set by default? Do they default to something on the backend?
| self, | ||
| client_id: str, | ||
| client_secret: str, | ||
| endpoint: str = "https://api.rapidata.ai", |
There was a problem hiding this comment.
Is this supposed to be hardcoded?
There was a problem hiding this comment.
it's a sensible default value I'd say (if it was correct lol)
| class TestClassifyOrder(unittest.TestCase): | ||
|
|
||
| def setUp(self): | ||
| self.rapi = setup_client() | ||
|
|
||
| def test_classify_order(self): | ||
| new_classify_order(self.rapi) | ||
|
|
||
| def test_free_text_input_order(self): | ||
| new_free_text_order(self.rapi) | ||
|
|
||
| def test_compare_order(self): | ||
| new_compare_order(self.rapi) |
There was a problem hiding this comment.
no, but the python client validates the call and the response, so if either the validation or the backend complains, the test will fail.
No description provided.