Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to capacitor 6 #46

Merged

Conversation

niconaso
Copy link
Contributor

Migration to Capacitor 6

@Snouzy
Copy link

Snouzy commented Apr 20, 2024

I'm looking forward to it 😃 good job!

@EinfachHans
Copy link

@RaphaelWoude are you still maintaining this plugin? Can you merge this PR? 😊

@alexdabast
Copy link

@RaphaelWoude couldn't agree any more could you accept this merge ? :)

@afilp
Copy link

afilp commented Apr 22, 2024

Can you please merge this? Thanks a lot!

@RaphaelWoude
Copy link
Owner

Sorry for the wait. Not having a lot of time to work on Open Source at the moment.
Looking at the pull request now.

@RaphaelWoude
Copy link
Owner

RaphaelWoude commented Apr 22, 2024

Everything looks fine except for the verify-ios action. This was erroring out because our action was still running on IOS 12 even though this was set to the latest. Capacitor 6 needs IOS 14 with XCode 15.
I have updated this to IOS 14 for now. Please pull the changes from main.

@RaphaelWoude
Copy link
Owner

527e1cb

@niconaso
Copy link
Contributor Author

Everything looks fine except for the verify-ios action. This was erroring out because our action was still running on IOS 12 even through this was set to the latest. Capacitor 6 needs IOS 14 with XCode 15. I have updated this to IOS 14 for now. Please pull the changes from main.

@RaphaelWoude Done!

@RaphaelWoude
Copy link
Owner

LGTM! 🎉
Thank you for your contribution.

@RaphaelWoude RaphaelWoude merged commit 8078c93 into RaphaelWoude:main Apr 22, 2024
4 checks passed
@EinfachHans
Copy link

Thabk you everyone, one plugin less on my list to update to v6 😃

@gasci
Copy link

gasci commented Apr 22, 2024

I understand you brother. I am in the same situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants