Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CapacitorNativeSettings.podspec #26

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

adamvigneault
Copy link
Contributor

@adamvigneault adamvigneault commented Sep 30, 2022

Still getting the following errors when using this dependency with Capacitor 4 -- shouldn't the podspec also be bumped to target 13?

Thrown during build:

NativeSettingsPlugin.swift:2:8: compiling for iOS 12.0, but module 'Capacitor' has a minimum deployment target of iOS 13.0: /Users/ionic-cloud-team/Library/Developer/Xcode/DerivedData/App-bcnhnmaahexbnydurxfgfrwwvhxn/Build/Intermediates.noindex/ArchiveIntermediates/App/BuildProductsPath/Release-iphoneos/Capacitor/Capacitor.framework/Modules/Capacitor.swiftmodule/arm64-apple-ios.swiftmodule

Still getting the following errors when using this dependency with Capacitor 4 -- shouldn't the podspec also be bumped to target 13?

Thrown during build: `NativeSettingsPlugin.swift:2:8: compiling for iOS 12.0, but module 'Capacitor' has a minimum deployment target of iOS 13.0: /Users/ionic-cloud-team/Library/Developer/Xcode/DerivedData/App-bcnhnmaahexbnydurxfgfrwwvhxn/Build/Intermediates.noindex/ArchiveIntermediates/App/BuildProductsPath/Release-iphoneos/Capacitor/Capacitor.framework/Modules/Capacitor.swiftmodule/arm64-apple-ios.swiftmodule`
@RaphaelWoude
Copy link
Owner

RaphaelWoude commented Oct 3, 2022

Hi. It seems for me that Xcode sets it to min deployment target 13 by default. So I don't get this error at all.
But we should probably bump this to 13. Thank you for your contribution!

@RaphaelWoude RaphaelWoude merged commit 7908e12 into RaphaelWoude:main Oct 3, 2022
@RaphaelWoude
Copy link
Owner

Live in v4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants