fix: consolidate provider behaviour + fix multi-turn provider corruption - #37
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📥 CommitsReviewing files that changed from the base of the PR and between 25ab8e956e365b9a04873db224175a8c4163ade9 and 78b8644. 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughDeleted the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
size:M
vouch:trusted
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
… provider corruption Two fixes: 1. Remove duplicate Harness.ProviderSession behaviour — all session modules now use only Harness.Providers.ProviderBehaviour, eliminating conflicting callback warnings. Added missing @impl annotations and stop/1 to MockSession. 2. Fix toLegacyProvider in web store to recognize "cursor" and "opencode" — previously both were silently mapped to "codex", corrupting the provider on second turn and causing "cannot switch provider" errors. Also hardcodes experimentalApi: true in Codex initialize (was conditional on providerOptions), fixing collaborationMode rejection on turn/start. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ranvier2d2
force-pushed
the
fix/provider-behaviour-consolidation
branch
from
March 29, 2026 17:14
25ab8e9 to
78b8644
Compare
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harness.ProviderSessionbehaviour — all session modules now use onlyHarness.Providers.ProviderBehaviour, eliminating ~40 conflicting callback warnings at compile time. Added missing@implannotations andstop/1toMockSession.toLegacyProviderin web store to recognize"cursor"and"opencode"— previously both were silently mapped to"codex", corrupting the session provider on second turn and causing"cannot switch provider"errors for OpenCode and Cursor sessions.experimentalApi: truein Codex initialize (was conditional onproviderOptions), fixingcollaborationModerejection onturn/start.Test plan
mix compile --warnings-as-errorspasses with zero warningscollaborationModeerror🤖 Generated with Claude Code
Summary by CodeRabbit