Repository navigation
fix: desktop harness bundling + council top-5 harness fixes #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3514b68
1fe109e
013e3a1
4bbe0ae
e44897f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1550,6 +1550,7 @@ if (process.platform !== "win32") { | |||||||||
| isQuitting = true; | ||||||||||
| writeDesktopLogHeader("SIGINT received"); | ||||||||||
| clearUpdatePollTimer(); | ||||||||||
| stopHarness(); | ||||||||||
| stopBackend(); | ||||||||||
|
Comment on lines
+1553
to
1554
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 SIGINT/SIGTERM handlers stop harness before backend, opposite of before-quit handler The new
Suggested change
Was this helpful? React with 👍 or 👎 to provide feedback. |
||||||||||
| restoreStdIoCapture?.(); | ||||||||||
| app.quit(); | ||||||||||
|
|
@@ -1560,6 +1561,7 @@ if (process.platform !== "win32") { | |||||||||
| isQuitting = true; | ||||||||||
| writeDesktopLogHeader("SIGTERM received"); | ||||||||||
| clearUpdatePollTimer(); | ||||||||||
| stopHarness(); | ||||||||||
| stopBackend(); | ||||||||||
|
Comment on lines
+1564
to
1565
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 SIGTERM handler also stops harness before backend (same issue as SIGINT) Same ordering bug as in the SIGINT handler —
Suggested change
Was this helpful? React with 👍 or 👎 to provide feedback. |
||||||||||
| restoreStdIoCapture?.(); | ||||||||||
| app.quit(); | ||||||||||
|
|
||||||||||
Uh oh!
There was an error while loading. Please reload this page.