Skip to content

fix: provider conflict guard and missing plan_delta handler - #22

Closed
ranvier2d2 wants to merge 2 commits into
mainfrom
fix/ci-test-failures
Closed

ranvier2d2 wants to merge 2 commits into
mainfrom
fix/ci-test-failures

Conversation

@ranvier2d2

Copy link
Copy Markdown
Collaborator

Summary

  • ProviderCommandReactor: only enforce provider binding when there is an active session — first turn with explicit provider choice is now honoured
  • ProviderCommandReactor: prefer requested provider over thread default when no session exists
  • CodexAdapter: add codex/event/plan_deltaturn.proposed.delta mapping (was in codexEventMapping.ts but missing from the adapter)
  • Test mock: startSession now respects the provider field from the caller

Test plan

  • ProviderCommandReactor.test.ts — 19/19 pass (was 18/19)
  • CodexAdapter.test.ts — 18/18 pass (was 17/18)
  • bun typecheck — 0 errors
  • bun lint — 0 errors
  • bun fmt — clean

🤖 Generated with Claude Code

- ProviderCommandReactor: only enforce provider binding when there is
  an active session — a first turn with an explicit provider choice
  should be honoured, not rejected against the thread default
- ProviderCommandReactor: prefer the requested provider over the
  thread default when no active session exists
- ProviderCommandReactor test: mock startSession now respects the
  provider field from the caller instead of always using the harness
  default
- CodexAdapter: add codex/event/plan_delta → turn.proposed.delta
  mapping (was present in codexEventMapping.ts but missing from the
  adapter's own event handler)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@ranvier2d2 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 25 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 25 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5b7276e4-59b3-4153-9a59-988faf2383f1

📥 Commits

Reviewing files that changed from the base of the PR and between bbf49ad and afdebee.

📒 Files selected for processing (3)
  • apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts
  • apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
  • apps/server/src/provider/Layers/CodexAdapter.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-test-failures

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Mar 27, 2026
@github-actions github-actions Bot added size:XS and removed size:S labels Mar 27, 2026
@ranvier2d2

Copy link
Copy Markdown
Collaborator Author

Superseded by PR #21 which included the same fixes and was merged first.

@ranvier2d2 ranvier2d2 closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant