Repository navigation
test(browser): judge the modal test by drawn lines and pin a merged pull request - #435
Merged
Merged
Conversation
…ull request Fixture mode now judges Enter on an elided run by the line count growing, as ext mode did, rather than by a host expand call the fixture never makes. Ext mode opens vitejs/vite#23590, a merged pull request whose newest commit keeps a row with shared text beside a del and an ins; the open #21626 had drifted until no such row was left. The first o check presses o up to three times, since a parent can paint exactly its child's text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser modal test (
pnpm run test:modalinpackages/browser) failed on main in both modes for reasons in the test itself, not the editor. This fixes onlypackages/browser/test/modal.mjs.Fixture mode
expandconsole call, which the fixture never makes.Ext mode
rolldownDepPlugin.ts, with 3 merged rows and elided runs.WARN: o did not move the selectionwas not a bug. On an identifier, the first parent node can span exactly the same text, so oneopaints the same ranges. The check now pressesoup to three times; here the selection widened on the second press (exactRegex->{ exactRegex, prefixRegex }).Verification (headless Chromium only)
pnpm run test:modalexits 0.o. expandElided went from 34 to 54 lines.🤖 Generated with Claude Code