Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore whitespaces at the end of title #PLTM-233 #2

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat: ignore whitespaces at the end of title #PLTM-233 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/get-tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
const getTasks = (source) => {
// Matches the prefix of the string containg only issue references delimited with whitespaces
const prefixWithRefsRegex = /((\s+|^)#[A-Z]{2,10}-\d+)+$/;
const prefixWithRefsRegex = /((\s+|^)#[A-Z]{2,10}-\d+)+\s*$/;
const [prefix] = source.match(prefixWithRefsRegex) || [''];
// Picks individual issue references from the string
const taskRefRegex = /(?<=(\s|^)#)[A-Z]{2,10}-\d+/g;
Expand Down
6 changes: 6 additions & 0 deletions lib/get-tasks.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ const correctSources = [
{ taskId: "BUNNY-1" }
]
],
[
"This PR closes #BUNNY-1 ",
[
{ taskId: "BUNNY-1" }
]
],
[
"This PR has duplicated reference #BUNNY-1 #BUNNY-1",
[
Expand Down