Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow model selection on the frontend #187

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anthony2261
Copy link
Collaborator

Issue #, if available:
#171

Description of changes:
Add listbox on the settings page to allow choosing preferred model

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@anthony2261 anthony2261 requested a review from RamiAwar June 5, 2024 09:35
@anthony2261 anthony2261 linked an issue Jun 5, 2024 that may be closed by this pull request
@RamiAwar
Copy link
Owner

RamiAwar commented Jun 5, 2024

I was about to work on this yesterday, I thought adding this on the conversation itself is nicer (then you can easily switch). What do you think?

Edit: Also what chatgpt does
image

@anthony2261
Copy link
Collaborator Author

Yeah I like the way it looks, how about both on the settings page and in the chat?

@RamiAwar
Copy link
Owner

After our discussion, agreed to delay this for a while.

Other models seems to be performing much worse in some ways (even though they are more powerful). So let's wait until we have a regression test suite, then we can enable some of those models after testing them thoroughly.

@RamiAwar
Copy link
Owner

I think once we tackle this again, it makes sense to refactor it in a generic way so as to support different LLMs + local LLMs potentially. Code for this is pretty unorganized and very specific to open AI right now (settings and validation, selecting the LLM in code, etc.)

@syedazharmbnr1
Copy link

After our discussion, agreed to delay this for a while.

Other models seems to be performing much worse in some ways (even though they are more powerful). So let's wait until we have a regression test suite, then we can enable some of those models after testing them thoroughly.

waiting for your feedback update for above

@RamiAwar
Copy link
Owner

RamiAwar commented Jul 7, 2024

Yeah this is postponed for a bit until we finish the evaluation pipeline.

Once we have that, we'll be able to evaluate models quickly and decide whether or not we want to enable them in DataLine.

Our goal isn't to just "support" lots of models, our goal is to allow users to pick among high quality options that all work. There is a minimum bar we want to maintain here, otherwise someone might come and try DataLine with GPT4o and decide that DataLine is bad (meanwhile the model itself is the problem). It's in our collective best interest to prevent that from happening 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a model picker
3 participants