Add macro to enable tip types for supported hardware only

[ia]

• Please check if the PR fulfills these requirements

• The changes have been tested locally
• There are no breaking changes

• What kind of change does this PR introduce?
  Enable Soldering Tip Type routines for supported hardware only.

• What is the current behavior?
  There are parts of code which are not relevant for all supported models, but yet the code is compiled & takes space on flash.

• What is the new behavior (if this is a feature change)?

• add TIP_TYPE_SUPPORT macro;
• enable related functions using the macro;
• enable TIP_TYPE_SUPPORT only for TS101 and Pinecil v2 as main targets for this feature;
• put Soldering Tip Type down the list in the settings, since it's optional.

• Other information:

Hello. I understand that this is raw & experimental feature. And I'm sorry I wasn't around when it was implemented, because probably even back then I would suggest the same what I propose now. When I was testing some translations on TS80P, I did end up with this:

Apparently, Soldering Tip Type is enabled for TS80P but none of available options (even Auto) are picked from the related switch/case block. But instead of fixing the symptom (i.e., just enable Auto for TS80P & others), I took some liberty to look around the related parts of code scattered in the project and came out with this suggestion. Further I will add a couple of comments as code review to clarify the decisions.

And just as an illustration - the results which I did get for TS80P/EN:

• build from the current dev:

Memory region         Used Size  Region Size  %age Used
             ROM:       41488 B        46 KB     88.08%

• build with this patch:

Memory region         Used Size  Region Size  %age Used
             ROM:       41420 B        46 KB     87.93%

I know that ~0.15% is just laughable, but to keep beefing up code base with unused code for some of the targets is just not quite reasonable approach, while the same space can be used for really useful features & code in the future.

Please, let me know what you think.

[ia]

Basically, I try to make the similar approach as for PROFILE_SUPPORT: we just enable everything related under the macro.

[ia]

Implement duplicated tipType_t stub for two reasons:

• TIP_TYPE_MAX = 0 for settings struct to avoid compile-time error and set 0/auto as default right there for non-supported models;
• TIP_TYPE_AUTO = 0 for backward compatibility with the stub function (see below).

[ia]

Instead of twisting my head about how to do it inside of the existed instance of getUserSelectedTipResistance(), I thought that the most simple & straight-forward approach is just to make the duplicated stub with the single return.

[ia]

I took liberty to move the setting down inside of the soldering menu since in the UX design & usability usually they put variable/non-constant options closer to "the end" of "the list". So while temperature settings are applied to nearly every target (hence, "first in a row"), targets with support of different tips are limited. Just for the same reason we don't put "[thermo] profiles" submenu in the top of the list.

[ia]

And the original problem with displaying tip type setting on TS80P takes root probably here because none of these macros inside lookupTipName() enabled, except TIPTYPE_TS80 but there is a tiny mistype in the macro usage. But even if we will fix the typo, the code probably won't compile because the tipType_t::TS80_4_5_OHM is commented & disabled.

UPD. Yeap (this is from dev for TS80P just with fixed typo):

Core/Src/Settings.cpp: In function 'const char* lookupTipName()':
Core/Src/Settings.cpp:323:19: error: 'TS80_4_5_OHM' is not a member of 'tipType_t'
  323 |   case tipType_t::TS80_4_5_OHM:
      |                   ^~~~~~~~~~~~

[Ralim]

I agree this is a cleaner way to do this

[Ralim]

Thank you for this, definitely glad you cleaned it up, and my bad for not doing this from the start 😁

[ia]

Thank you for this, definitely glad you cleaned it up, and my bad for not doing this from the start 😁

Please, don't worry. As I say I understand this is very raw & experimental feature. And it's better to separate this early while it have only prototypes, than some time later for larger code base. You're always welcome. ;)

As of for the feature itself, I really think it will be super great if, let's say, Pine short tips can be used not only with Pinecil V2 but with other T12-compatible irons.

[Ralim]

As of for the feature itself, I really think it will be super great if, let's say, Pine short tips can be used not only with Pinecil V2 but with other T12-compatible irons.

That was the motivating goal here :)