Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing languages & reverting unwanted weblate changes #1548

Merged
merged 5 commits into from
Jan 30, 2023

Conversation

discip
Copy link
Collaborator

@discip discip commented Jan 28, 2023

fixes #1547
closes #1544

@discip
Copy link
Collaborator Author

discip commented Jan 28, 2023

@Ralim
I have no clue what I should do to make shellcheck happy.
Please help.

@Ralim
Copy link
Owner

Ralim commented Jan 28, 2023

Oops looks like shellcheck is broken.
I can override it for now so no drama.

Also looks like Weblate doesnt have a way for me to stop it stripping these newlines so thinking of just removing it and trying to find another option. Thoughts?

@discip
Copy link
Collaborator Author

discip commented Jan 28, 2023

Newlines are not the problem, but the unit getting set to true is annoying.

I could have used Weblate to change what this PR will, but I'm not sure how strong the butterfly effect would be.

Unfortunately, I have no idea what other option to consider.

I will hereby also implement the changes pushed by weblate users.

@discip discip marked this pull request as draft January 28, 2023 12:54
@discip discip marked this pull request as ready for review January 28, 2023 13:16
@discip
Copy link
Collaborator Author

discip commented Jan 28, 2023

@Ralim
This is good to go now.
Also implemented the PRs made by weblate users #1544. 😊

@Ralim Ralim merged commit 586fd3b into Ralim:dev Jan 30, 2023
@Ralim
Copy link
Owner

Ralim commented Jan 30, 2023

Thank you for doing this; going to take out weblate and look for a better option.

@discip discip deleted the fix_languages branch January 30, 2023 06:40
@discip
Copy link
Collaborator Author

discip commented Jan 30, 2023

As always:
Happy to be able to help. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screen is "messed up" with the detailed soldering screen
2 participants