Skip to content

Claim drop on event message received #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 14, 2023
Merged

Claim drop on event message received #559

merged 5 commits into from
Aug 14, 2023

Conversation

Rakambda
Copy link
Member

@Rakambda Rakambda commented Aug 14, 2023 •
edited
Loading

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

New Feature

Description

Start syncying inventory when a drop is completed based on an event sent from the WS.
Thanks to rdavydov/Twitch-Channel-Points-Miner-v2#333 (comment) for noticing this event.

Adds new events:

  • DropClaimedChannelEvent
  • DropProgressChannelEvent

@Rakambda Rakambda self-assigned this Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #559 (49bc4a6) into develop (1ef887b) will increase coverage by 0.11%.
The diff coverage is 92.00%.

@@              Coverage Diff              @@
##             develop     #559      +/-   ##
=============================================
+ Coverage      84.88%   84.99%   +0.11%     
- Complexity      1045     1064      +19     
=============================================
  Files            203      206       +3     
  Lines           3328     3373      +45     
  Branches         251      253       +2     
=============================================
+ Hits            2825     2867      +42     
- Misses           445      449       +4     
+ Partials          58       57       -1
Flag Coverage Δ
unittests-miner 85.38% <92.00%> (+0.10%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ner/miner/handler/PubSubMessageHandlerAdapter.java 30.18% <0.00%> (-1.19%) ⬇️
...iner/miner/event/impl/DropClaimedChannelEvent.java 83.33% <83.33%> (ø)
...ner/miner/event/impl/DropProgressChannelEvent.java 90.90% <90.90%> (ø)
...ner/miner/api/ws/data/request/topic/TopicName.java 84.61% <100.00%> (+1.28%) ⬆️
...channelpointsminer/miner/factory/MinerFactory.java 100.00% <100.00%> (ø)
...ner/miner/factory/PubSubMessageHandlerFactory.java 100.00% <100.00%> (ø)
...nelpointsminer/miner/handler/ClaimDropHandler.java 100.00% <100.00%> (ø)
...rakambda/channelpointsminer/miner/miner/Miner.java 96.96% <100.00%> (+0.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jabbink
Copy link
Contributor

jabbink commented Aug 14, 2023

Thanks to rdavydov/Twitch-Channel-Points-Miner-v2#333 (comment) for noticing this event.

rdavydov/Twitch-Channel-Points-Miner-v2#333 (comment) better suitable event I think

@Rakambda Rakambda merged commit b50d5d2 into develop Aug 14, 2023
@Rakambda Rakambda deleted the feature/drop-message branch August 14, 2023 20:13
@Rakambda Rakambda changed the title Claim drop on event message received Claim drop on event message received on clients other than TV Aug 15, 2023
@Rakambda
Copy link
Member Author

Edited in 14fa5a4 & c54a96a

@Rakambda Rakambda changed the title Claim drop on event message received on clients other than TV Claim drop on event message received Aug 15, 2023
Rakambda added a commit that referenced this pull request Sep 9, 2023
@Rakambda @dependabot
@renovate @couchoud-t
Next version (#579)
ca3e93f 
* chore(deps): bump junit-version from 5.9.3 to 5.10.0 (#551)

* chore(deps): bump junit-version from 5.9.3 to 5.10.0

Bumps `junit-version` from 5.9.3 to 5.10.0.

Updates `org.junit.jupiter:junit-jupiter-api` from 5.9.3 to 5.10.0
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.9.3...r5.10.0)

Updates `org.junit.jupiter:junit-jupiter-params` from 5.9.3 to 5.10.0
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.9.3...r5.10.0)

Updates `org.junit.jupiter:junit-jupiter-engine` from 5.9.3 to 5.10.0
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.9.3...r5.10.0)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.junit.jupiter:junit-jupiter-params
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.junit.jupiter:junit-jupiter-engine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Properly override junit version in spring

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Couchoud <[email protected]>

* chore(deps): bump org.apache.commons:commons-lang3 from 3.12.0 to 3.13.0 (#555)

Bumps org.apache.commons:commons-lang3 from 3.12.0 to 3.13.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-lang3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump com.codeborne:selenide from 6.16.1 to 6.17.0 (#556)

Bumps [com.codeborne:selenide](https://github.com/selenide/selenide) from 6.16.1 to 6.17.0.
- [Release notes](https://github.com/selenide/selenide/releases)
- [Changelog](https://github.com/selenide/selenide/blob/main/CHANGELOG.md)
- [Commits](selenide/selenide@v6.16.1...v6.17.0)

---
updated-dependencies:
- dependency-name: com.codeborne:selenide
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump unirest-version from 4.0.3 to 4.0.4 (#557)

* CI

* CI

* chore(deps): bump io.spring.dependency-management from 1.1.2 to 1.1.3 (#558)

Bumps [io.spring.dependency-management](https://github.com/spring-gradle-plugins/dependency-management-plugin) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/spring-gradle-plugins/dependency-management-plugin/releases)
- [Commits](spring-gradle-plugins/dependency-management-plugin@v1.1.2...v1.1.3)

---
updated-dependencies:
- dependency-name: io.spring.dependency-management
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Claim drop on event message received (#559)

* feat: claim drop on message received

* feat: use drop claim event

* feat: event on drop progress

* fix: use actual percentage

* doc: fix doc link

* User drops events only on non android-tv clients

* fix: user_drop_event use own user id

* chore(deps): update dependency gradle to v8.3 (#560)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): bump com.codeborne:selenide from 6.17.0 to 6.17.1 (#561)

* chore(deps): bump flyway-version from 9.21.1 to 9.21.2 (#562)

Bumps `flyway-version` from 9.21.1 to 9.21.2.

Updates `org.flywaydb:flyway-core` from 9.21.1 to 9.21.2
- [Release notes](https://github.com/flyway/flyway/releases)
- [Commits](flyway/flyway@flyway-9.21.1...flyway-9.21.2)

Updates `org.flywaydb:flyway-mysql` from 9.21.1 to 9.21.2
- [Release notes](https://github.com/flyway/flyway/releases)
- [Commits](flyway/flyway@flyway-9.21.1...flyway-9.21.2)

---
updated-dependencies:
- dependency-name: org.flywaydb:flyway-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.flywaydb:flyway-mysql
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): update actions/checkout action to v3.6.0 (#563)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): bump org.springframework.boot from 3.1.2 to 3.1.3 (#564)

Bumps [org.springframework.boot](https://github.com/spring-projects/spring-boot) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.1.2...v3.1.3)

---
updated-dependencies:
- dependency-name: org.springframework.boot
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 🔄 synced file(s) with Rakambda/rakambda-github-files (#565)

Co-authored-by: undefined <[email protected]>

* chore(deps): bump org.mariadb.jdbc:mariadb-java-client (#568)

Bumps [org.mariadb.jdbc:mariadb-java-client](https://github.com/mariadb-corporation/mariadb-connector-j) from 3.1.4 to 3.2.0.
- [Release notes](https://github.com/mariadb-corporation/mariadb-connector-j/releases)
- [Changelog](https://github.com/mariadb-corporation/mariadb-connector-j/blob/master/CHANGELOG.md)
- [Commits](mariadb-corporation/mariadb-connector-j@3.1.4...3.2.0)

---
updated-dependencies:
- dependency-name: org.mariadb.jdbc:mariadb-java-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump com.codeborne:selenide from 6.17.1 to 6.17.2 (#567)

Bumps [com.codeborne:selenide](https://github.com/selenide/selenide) from 6.17.1 to 6.17.2.
- [Release notes](https://github.com/selenide/selenide/releases)
- [Changelog](https://github.com/selenide/selenide/blob/main/CHANGELOG.md)
- [Commits](selenide/selenide@v6.17.1...v6.17.2)

---
updated-dependencies:
- dependency-name: com.codeborne:selenide
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump org.xerial:sqlite-jdbc from 3.42.0.0 to 3.42.0.1 (#566)

Bumps [org.xerial:sqlite-jdbc](https://github.com/xerial/sqlite-jdbc) from 3.42.0.0 to 3.42.0.1.
- [Release notes](https://github.com/xerial/sqlite-jdbc/releases)
- [Changelog](https://github.com/xerial/sqlite-jdbc/blob/master/CHANGELOG)
- [Commits](xerial/sqlite-jdbc@3.42.0.0...3.42.0.1)

---
updated-dependencies:
- dependency-name: org.xerial:sqlite-jdbc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump info.picocli:picocli from 4.7.4 to 4.7.5 (#569)

Bumps [info.picocli:picocli](https://github.com/remkop/picocli) from 4.7.4 to 4.7.5.
- [Release notes](https://github.com/remkop/picocli/releases)
- [Changelog](https://github.com/remkop/picocli/blob/main/RELEASE-NOTES.md)
- [Commits](remkop/picocli@v4.7.4...v4.7.5)

---
updated-dependencies:
- dependency-name: info.picocli:picocli
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Readme.adoc

* Log into folder relative to PWD

* chore(deps): bump flyway-version from 9.21.2 to 9.22.0 (#572)

Bumps `flyway-version` from 9.21.2 to 9.22.0.

Updates `org.flywaydb:flyway-core` from 9.21.2 to 9.22.0
- [Release notes](https://github.com/flyway/flyway/releases)
- [Commits](flyway/flyway@flyway-9.21.2...flyway-9.22.0)

Updates `org.flywaydb:flyway-mysql` from 9.21.2 to 9.22.0
- [Release notes](https://github.com/flyway/flyway/releases)
- [Commits](flyway/flyway@flyway-9.21.2...flyway-9.22.0)

---
updated-dependencies:
- dependency-name: org.flywaydb:flyway-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.flywaydb:flyway-mysql
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump org.xerial:sqlite-jdbc from 3.42.0.1 to 3.43.0.0 (#570)

Bumps [org.xerial:sqlite-jdbc](https://github.com/xerial/sqlite-jdbc) from 3.42.0.1 to 3.43.0.0.
- [Release notes](https://github.com/xerial/sqlite-jdbc/releases)
- [Changelog](https://github.com/xerial/sqlite-jdbc/blob/master/CHANGELOG)
- [Commits](xerial/sqlite-jdbc@3.42.0.1...3.43.0.0)

---
updated-dependencies:
- dependency-name: org.xerial:sqlite-jdbc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump org.slf4j:slf4j-api from 2.0.7 to 2.0.9 (#574)

Bumps org.slf4j:slf4j-api from 2.0.7 to 2.0.9.

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): update actions/checkout action to v4 (#573)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update mikepenz/action-junit-report action to v4 (#575)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): bump com.codeborne:selenide from 6.17.2 to 6.18.0 (#576)

* chore(deps): bump com.codeborne:selenide from 6.17.2 to 6.18.0

Bumps [com.codeborne:selenide](https://github.com/selenide/selenide) from 6.17.2 to 6.18.0.
- [Release notes](https://github.com/selenide/selenide/releases)
- [Changelog](https://github.com/selenide/selenide/blob/main/CHANGELOG.md)
- [Commits](selenide/selenide@v6.17.2...v6.18.0)

---
updated-dependencies:
- dependency-name: com.codeborne:selenide
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: imports

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Couchoud <[email protected]>

* chore(deps): bump com.github.ben-manes.versions from 0.47.0 to 0.48.0 (#577)

Bumps com.github.ben-manes.versions from 0.47.0 to 0.48.0.

---
updated-dependencies:
- dependency-name: com.github.ben-manes.versions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add new prediction result : RATE_LIMITED (#578)

* Bump version

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Thomas Couchoud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rakambda Rakambda

Labels
app: ⛏️ miner type: 🧱 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rakambda @jabbink