This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Support dynamic salt lengths in ISPConfig password driver #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the "CouldNotSaveNewPassword" error when changing password via settings for mailbox created/updated in newer ISPConfig versions. Additionally: * Splits logic into smaller methods * Adds log method to avoid same ifs * Adds more log output in case of errors * Updates cryptPassword to behave the same as in ISPConfig (more secure salt generation) * Fixes some code styles
…g password driver
the-djmaze
pushed a commit
to the-djmaze/snappymail
that referenced
this pull request
Mar 10, 2022
|
Hello, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "CouldNotSaveNewPassword" error when changing password via settings for mailboxes created/updated in newer ISPConfig versions.
Additionally:
This should fix:
#2072
#1946
Should include all fixes according ISPConfig solved in some other way in:
#2095
This still doesn't add support for multi server environments:
#733
I implemented the code with a PHP language level of 7.0. Everything above is supported.
Wasn't sure if there are any style rules but I did my best to match with the style used in other plugins.
I tested the code with a local environment and on production servers.
The password salt detection is backwards compatible with old passwords using a fixed salt length.
So this shouldn't have any side effects on existing installations.