Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabler icons #9

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Add tabler icons #9

merged 6 commits into from
Oct 10, 2024

Conversation

jordancalhoun
Copy link
Contributor

No description provided.

@jordancalhoun
Copy link
Contributor Author

This PR accidentally changes the lucide stroke from 1.5 to 2 which will need corrected. If you are open to external support I'm happy to submit a few more PRs I have lined up!

@eelcoj
Copy link
Collaborator

eelcoj commented Oct 10, 2024

@jordancalhoun Thanks! Much appreciated. ❤️ Tabler is quite a massive collection of icons—never heard of it!

I like the refactor you did around the library configs (lib/rails_icons/icon_configs/*_config.rb). There are though a few unintended changes too. Most notably changing " to ' and a "test/dummy/log/test.log" file. Both should be easy (be standardrb --fix for the quotes).

@jordancalhoun
Copy link
Contributor Author

Oof, my bad I'll get those fixed!

@jordancalhoun
Copy link
Contributor Author

Changes have been made, let me know if you see any other issues

@eelcoj eelcoj merged commit 1ba84ab into Rails-Designer:main Oct 10, 2024
@eelcoj
Copy link
Collaborator

eelcoj commented Oct 10, 2024

Thanks for this @jordancalhoun 🙌

@jordancalhoun
Copy link
Contributor Author

I failed to bump the version number with this release, do you want to handle that @eelcoj?

@eelcoj
Copy link
Collaborator

eelcoj commented Oct 10, 2024

Yep, I will cut a release soon! 👍

@eelcoj
Copy link
Collaborator

eelcoj commented Oct 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants