Skip to content

Fix miscellaneous spec failures for Crystal 1.18 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ragmaanir merged 3 commits into from
Nov 15, 2025
Merged

Fix miscellaneous spec failures for Crystal 1.18 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b50f22
proper ANSI closing codes
HertzDevil Nov 11, 2025
82c60e8
always colorize
HertzDevil Nov 11, 2025
63138bc
single-line block
HertzDevil Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/power_assert_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe Microtest::PowerAssert do

assert reflect(yielding(1) { |x| x }) == CallNode.new(
%[yielding],
%[yielding(1) do |x|\n x\nend],
%[yielding(1) do |x| x end],
2001,
EmptyNode.new,
[TerminalNode.new("1", 1)] of Node,
Expand Down
8 changes: 4 additions & 4 deletions spec/termart_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ describe Microtest::Termart do
test "grouped_lines with color" do
res = grouped_lines(["A: aaa"], RED, colorize: true)

assert res == %{\e[38;2;220;0;0m◆\e[0m A: aaa\n}
assert res == %{\e[38;2;220;0;0m◆\e[39m A: aaa\n}

res = grouped_lines(["A: aaa", "B: bbb", "C: ccc"], RED, colorize: true)

assert res == <<-STR
\e[38;2;220;0;0m┏\e[0m A: aaa
\e[38;2;220;0;0m┃\e[0m B: bbb
\e[38;2;220;0;0m┗\e[0m C: ccc\n
\e[38;2;220;0;0m┏\e[39m A: aaa
\e[38;2;220;0;0m┃\e[39m B: bbb
\e[38;2;220;0;0m┗\e[39m C: ccc\n
STR
end
end
2 changes: 1 addition & 1 deletion src/microtest/termart.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module Microtest

private def colorized_io(fg : RGB? = nil, bg : RGB? = nil, m : Colorize::Mode? = nil, &)
if colorize?
c = Colorize.with
c = Colorize.with.toggle(true)
c = c.fore(fg) if fg
c = c.mode(m) if m
c = c.back(bg) if bg
Expand Down