Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-pipelines] build matrix #111

Merged
merged 3 commits into from
May 13, 2020
Merged

[azure-pipelines] build matrix #111

merged 3 commits into from
May 13, 2020

Conversation

Raffaello
Copy link
Owner

@Raffaello Raffaello commented May 12, 2020

  • Matrix pipeline

to be triggered manually...


  • meanwhile increase some code coverage.

@Raffaello Raffaello self-assigned this May 12, 2020
@Raffaello Raffaello added configuration cmake or project related code, configuaration documentation Improvements or additions to documentation labels May 12, 2020
@Raffaello Raffaello force-pushed the 37-build-matrix-flags branch from 8487d03 to 77408bd Compare May 12, 2020 22:49
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files           2        2           
  Lines         294      294           
=======================================
  Hits          240      240           
  Misses         54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78af53...a072502. Read the comment docs.

@Raffaello Raffaello force-pushed the 37-build-matrix-flags branch 15 times, most recently from 592a949 to 44321f6 Compare May 12, 2020 23:39
@Raffaello Raffaello force-pushed the 37-build-matrix-flags branch 9 times, most recently from c82d815 to 9c2bc5c Compare May 13, 2020 00:12
@Raffaello Raffaello force-pushed the 37-build-matrix-flags branch from 9c2bc5c to cf5935f Compare May 13, 2020 00:14
@Raffaello Raffaello marked this pull request as ready for review May 13, 2020 00:33
@Raffaello Raffaello linked an issue May 13, 2020 that may be closed by this pull request
7 tasks
@Raffaello Raffaello changed the title [auzre-pipelines] build matrix [azure-pipelines] build matrix May 13, 2020
@todo
Copy link

todo bot commented May 13, 2020

how to verify?

mocks and call some private method once?


// TODO how to verify?
// BODY mocks and call some private method once?
std::string title = ::testing::UnitTest::GetInstance()->current_test_info()->name();
VgaTerminal term = VgaTerminal(title, SDL_WINDOW_HIDDEN, -1, 0);
term.writeXY(0, 24, "a", 7, 1);
term.writeXY(0, 23, "a", 7, 1);


This comment was generated by todo based on a TODO comment in a072502 in #111. cc @Raffaello.

@todo
Copy link

todo bot commented May 13, 2020

how to verify without mocking?

only with mocking at the moment i have a solution but require some restructure...


// TODO: how to verify without mocking?
// BODY only with mocking at the moment i have a solution but require some restructure...
std::string title = ::testing::UnitTest::GetInstance()->current_test_info()->name();
VgaTerminal term = VgaTerminal(title, SDL_WINDOW_HIDDEN, -1, 0);
term.write("Hello", 7, 1);
term.render();


This comment was generated by todo based on a TODO comment in a072502 in #111. cc @Raffaello.

@todo
Copy link

todo bot commented May 13, 2020

how to verify without mocking?

only with mocking at the moment i have a solution but require some restructure...


// TODO: how to verify without mocking?
// BODY only with mocking at the moment i have a solution but require some restructure...
std::string title = ::testing::UnitTest::GetInstance()->current_test_info()->name();
VgaTerminal term = VgaTerminal(title, SDL_WINDOW_HIDDEN, -1, 0);
term.write("Hello", 7, 1);
term.render();


This comment was generated by todo based on a TODO comment in a072502 in #111. cc @Raffaello.

@todo
Copy link

todo bot commented May 13, 2020

how to verify without mocking?

only with mocking at the moment i have a solution but require some restructure...


// TODO: how to verify without mocking?
// BODY only with mocking at the moment i have a solution but require some restructure...
std::string title = ::testing::UnitTest::GetInstance()->current_test_info()->name();
VgaTerminal term = VgaTerminal(title, 0, -1, 0);
term.write("Hello", 7, 1);
term.render();


This comment was generated by todo based on a TODO comment in a072502 in #111. cc @Raffaello.

@todo
Copy link

todo bot commented May 13, 2020

_defaultChar_t consideration

this test might bring the consideration to return/have something different


// TODO _defaultChar_t consideration
// BODY this test might bring the consideration to return/have something different
// rather that {0, 0, 0} when wrong input for .at
std::string title = ::testing::UnitTest::GetInstance()->current_test_info()->name();
VgaTerminal term = VgaTerminal(title, SDL_WINDOW_HIDDEN, -1, 0);
SDL_Rect vp = term.getViewport();


This comment was generated by todo based on a TODO comment in a072502 in #111. cc @Raffaello.

Copy link
Owner Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

Clones added
============
- sdl2-vga-terminal/test/tests.cpp  2
         

See the complete overview on Codacy

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Raffaello
Copy link
Owner Author

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files           2        2           
  Lines         294      294           
=======================================
  Hits          240      240           
  Misses         54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78af53...a072502. Read the comment docs.

the bot reported wrongly there is a codecov increase on codecov site is displaying that...

@Raffaello Raffaello merged commit f655025 into master May 13, 2020
@Raffaello Raffaello deleted the 37-build-matrix-flags branch May 13, 2020 19:31
Raffaello added a commit that referenced this pull request May 13, 2020
* [auzre-pipelines] linux build matrix

* [azure-pipelines] matrix pipeline

* add tests and consideration toward 0.3

corrected typo in README.md

Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration cmake or project related code, configuaration documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI build matrix extension (Windows)
1 participant