Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VgaTerminal] Decouple drawing functionality from vgaterminal to window #122

Closed
3 tasks done
Raffaello opened this issue May 16, 2020 · 1 comment · Fixed by #86
Closed
3 tasks done

[VgaTerminal] Decouple drawing functionality from vgaterminal to window #122

Raffaello opened this issue May 16, 2020 · 1 comment · Fixed by #86
Assignees
@Raffaello
Labels
refactor improve the code without enhancing in functionalities
Milestone
Version 0.3.0

Comments

@Raffaello
Copy link
Owner

Raffaello commented May 16, 2020 •
edited
Loading

  • line 117-121 for eg.

  • Also adjust the Window "interface" respectively.

  • window tests
@Raffaello Raffaello added this to the Version 0.3.0 milestone May 16, 2020
@Raffaello Raffaello added the refactor improve the code without enhancing in functionalities label May 16, 2020
@Raffaello Raffaello changed the title decouple drawing functionality from vgaterminal to window [VgaTerminal] Decouple drawing functionality from vgaterminal to window May 16, 2020
@Raffaello Raffaello self-assigned this May 16, 2020
@Raffaello
Copy link
Owner Author

window is not really nothing special, more a wrapper around SDL functionality...
later on should be reconsidered differently and instead of inheritance using composition....

@Raffaello Raffaello linked a pull request May 16, 2020 that will close this issue
v0.3.0 #86
Merged
9 tasks
Raffaello added a commit that referenced this issue May 16, 2020
@Raffaello
decouple VgaTerminal drawing functionality to Window. #122
ec37636
Raffaello added a commit that referenced this issue May 16, 2020
@Raffaello
decouple VgaTerminal drawing functionality to Window. Fix #122
63dbb62
Raffaello added a commit that referenced this issue May 22, 2020
@Raffaello
v0.3.0 (#86)
777012d 
* preparing for v0.3.0

* rebase

* add clearLine method. fix #42

* update readme. fix #121

* for loop refactor in a C++ way

* refactor _setCharAtCursorPosition name

* refactor clearLine

* add fill method. Fix #113

* decouple VgaTerminal drawing functionality to Window. Fix #122

* cursor blinking flag. Fix #39

* cursor speed from enum class, partially fix #38

* [cmake] macro to generate example. Fix #126

* update version string to 0.3.0 fixes #129

* build switch for precise timer,fixes #131 cursor blinking test macOS

* replace -fPIC with CMAKE_POSITION_INDEPENDENT_CODE flag. fix #132

* [appveyor | macOS] disable precise timer fix #131

* [TuiTerminal] phase 1 ver 0.1-showcase and example. Fixes #133

* [cmake] using GoogleTest module and macro for test. Fixes#128

* TODOs review

* define specific runtime_error exception. Fixes # 139

* fixes #91

* [wont fix] snapshot testing on CI. Fixes #141

* publish test report and code coverage on analysis pipeline. Fixes #143

* publish test reports even if test task failed. Fixes #130

* add .gittribute

* [lint] line ending LF

* [lint] replace TABS with SPACES

* [lint] end line LF. [azure-pipelines] cpplint analisys

* [azure-pipelines] add cpplint job. Fixes #140

* compilers warning fixes #146

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raffaello Raffaello

Labels
refactor improve the code without enhancing in functionalities
Projects
None yet
Milestone
Version 0.3.0
Development

Successfully merging a pull request may close this issue.

v0.3.0 Raffaello/sdl2-vga-terminal
1 participant
@Raffaello