checkpoint: remove nodeerror (30%)

RafaelGSS · Dec 30, 2022 · ecd6065 · ecd6065 · ronag · Jan 3, 2023
1 parent 0639cf7
commit ecd6065
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 16 deletions.
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -2027,10 +2027,10 @@ function readableStreamReaderGenericInitialize(reader, stream) {
 
 function readableStreamDefaultReaderRelease(reader) {
   readableStreamReaderGenericRelease(reader);
-  readableStreamDefaultReaderErrorReadRequests(
-    reader,
-    new ERR_INVALID_STATE.TypeError('Releasing reader')
-  );
+  // readableStreamDefaultReaderErrorReadRequests(
+  //   reader,
+  //   new ERR_INVALID_STATE.TypeError('Releasing reader')
+  // );
 }
 
 function readableStreamDefaultReaderErrorReadRequests(reader, e) {
@@ -2063,15 +2063,15 @@ function readableStreamReaderGenericRelease(reader) {
   assert(stream[kState].reader === reader);
 
   if (stream[kState].state === 'readable') {
-    reader[kState].close.reject?.(
-      new ERR_INVALID_STATE.TypeError('Reader released'));
+    // reader[kState].close.reject?.(
+    //   new ERR_INVALID_STATE.TypeError('Reader released'));
   } else {
-    reader[kState].close = {
-      promise: PromiseReject(
-        new ERR_INVALID_STATE.TypeError('Reader released')),
-      resolve: undefined,
-      reject: undefined,
-    };
+    // reader[kState].close = {
+    //   promise: PromiseReject(
+    //     new ERR_INVALID_STATE.TypeError('Reader released')),
+    //   resolve: undefined,
+    //   reject: undefined,
+    // };
   }
   setPromiseHandled(reader[kState].close.promise);
 

diff --git a/lib/internal/webstreams/writablestream.js b/lib/internal/webstreams/writablestream.js
@@ -970,10 +970,9 @@ function writableStreamDefaultWriterRelease(writer) {
   } = writer[kState];
   assert(stream !== undefined);
   assert(stream[kState].writer === writer);
-  const releasedError =
-    new ERR_INVALID_STATE.TypeError('Writer has been released');
-  writableStreamDefaultWriterEnsureReadyPromiseRejected(writer, releasedError);
-  writableStreamDefaultWriterEnsureClosedPromiseRejected(writer, releasedError);
+  // const releasedError =
+  //   new ERR_INVALID_STATE.TypeError('Writer has been released'); writableStreamDefaultWriterEnsureReadyPromiseRejected(writer, releasedError);
+  // writableStreamDefaultWriterEnsureClosedPromiseRejected(writer, releasedError);
   stream[kState].writer = undefined;
   writer[kState].stream = undefined;
 }