Skip to content

Enable nullable ref types #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Enable nullable ref types #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c71590a
Enable nullable ref types
mauroservienti Sep 28, 2020
1774d92
Merge branch 'master' into nullable-ref-types
mauroservienti Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Radical/ChangeTracking/Change Management/Change.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public abstract class Change<T> : IChange<T>
/// The callback to invoke in order to
/// commit the cached value.
/// </summary>
protected CommitCallback<T> CommitCallback { get; }
protected CommitCallback<T>? CommitCallback { get; }

/// <summary>
/// Initializes a new instance of the <see cref="Change&lt;T&gt;"/> class.
Expand All @@ -31,7 +31,7 @@ public abstract class Change<T> : IChange<T>
/// <param name="rejectCallback">The reject callback.</param>
/// <param name="commitCallback">The commit callback.</param>
/// <param name="description">The description.</param>
protected Change(object owner, T valueToCache, RejectCallback<T> rejectCallback, CommitCallback<T> commitCallback, string description)
protected Change(object owner, T valueToCache, RejectCallback<T> rejectCallback, CommitCallback<T>? commitCallback, string description)
{
Ensure.That(owner).Named("owner").IsNotNull();
Ensure.That(rejectCallback).Named("rejectCallback").IsNotNull();
Expand Down
2 changes: 1 addition & 1 deletion src/Radical/Model/ChangeTracking/Properties/PropertyValueChange (Generic).cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public PropertyValueChange(object owner, string propertyName, T value, RejectCal
/// <param name="restoreCallback">The restore callback.</param>
/// <param name="commitCallback">The commit callback.</param>
/// <param name="description">The description.</param>
public PropertyValueChange(object owner, string propertyName, T value, RejectCallback<T> restoreCallback, CommitCallback<T> commitCallback, string description)
public PropertyValueChange(object owner, string propertyName, T value, RejectCallback<T> restoreCallback, CommitCallback<T>? commitCallback, string description)
: base(owner, value, restoreCallback, commitCallback, description)
{
PropertyName = propertyName;
Expand Down
2 changes: 2 additions & 0 deletions src/Radical/Radical.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<Nullable>enable</Nullable>
<LangVersion>9</LangVersion>
</PropertyGroup>

<PropertyGroup>
Expand Down