-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DashboardWithoutDndContext export that has no react-dnd DragDropContext #33
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage ? 83.41%
=========================================
Files ? 11
Lines ? 398
Branches ? 44
=========================================
Hits ? 332
Misses ? 66
Partials ? 0
Continue to review full report at Codecov.
|
This is awesome. Thank you! I would put the details that you have added to the readme to a separate file and link it. But, I'll do that when I merge. I'll merge this during the weekend and push a release. Again, thank you for the PR and Keep contributing to OSS! |
@Raathigesh You're welcome. I thank you. If you can release the npm package after the merge that would be great. |
What happened? no time for merging? When will the merge be? Thanks in advance. Im hoping it will be soon. |
Hope this gets merged soon! |
Hello @Raathigesh, would you have some time to merge this PR please? |
I can't merge this until the tests all pass |
Looks like it's code coverage issues |
@pcross616 my bad, sorry, this should be ok now right? I also renamed sample/components/widgets/HelloWorld/Index.jsx into index.jsx, because the sample was not running on my Linux ("npm run dev") |
Here is the PR related to our previous discussion #31 To be honest I think this is my very first PR on github!
I'm still not very comfortable with ES6/7 modules so please feel free to edit this if it's not right. I've not added a test but I'm not sure it's necessary. However I can confirm Dashboard and DashboardWithoutDndContext components run has expected in my React application.