Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DashboardWithoutDndContext export that has no react-dnd DragDropContext #33

Merged
merged 3 commits into from
May 23, 2018

Conversation

khelkun
Copy link
Contributor

@khelkun khelkun commented Sep 18, 2017

Here is the PR related to our previous discussion #31 To be honest I think this is my very first PR on github!

I'm still not very comfortable with ES6/7 modules so please feel free to edit this if it's not right. I've not added a test but I'm not sure it's necessary. However I can confirm Dashboard and DashboardWithoutDndContext components run has expected in my React application.

@codecov-io
Copy link

codecov-io commented Sep 18, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@7daccdc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage          ?   83.41%           
=========================================
  Files             ?       11           
  Lines             ?      398           
  Branches          ?       44           
=========================================
  Hits              ?      332           
  Misses            ?       66           
  Partials          ?        0
Impacted Files Coverage Δ
lib/components/Dashboard.js 100% <ø> (ø)
lib/index.js 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7daccdc...96b2fc0. Read the comment docs.

@khelkun khelkun changed the title Added DashboardWtihoutDndContext export that has no react-dnd DragDropContext Added DashboardWithoutDndContext export that has no react-dnd DragDropContext Sep 18, 2017
@Raathigesh
Copy link
Owner

Raathigesh commented Sep 19, 2017

This is awesome. Thank you! I would put the details that you have added to the readme to a separate file and link it. But, I'll do that when I merge.

I'll merge this during the weekend and push a release.

Again, thank you for the PR and Keep contributing to OSS!

@khelkun
Copy link
Contributor Author

khelkun commented Sep 19, 2017

@Raathigesh You're welcome. I thank you. If you can release the npm package after the merge that would be great.

@doppelgunner
Copy link

What happened? no time for merging? When will the merge be? Thanks in advance. Im hoping it will be soon.

@freenetbrasil
Copy link

freenetbrasil commented May 2, 2018

Hope this gets merged soon!

@khelkun
Copy link
Contributor Author

khelkun commented May 22, 2018

Hello @Raathigesh, would you have some time to merge this PR please?

@pcross616
Copy link
Collaborator

I can't merge this until the tests all pass

@pcross616
Copy link
Collaborator

Looks like it's code coverage issues

@khelkun
Copy link
Contributor Author

khelkun commented May 23, 2018

@pcross616 my bad, sorry, this should be ok now right? I also renamed sample/components/widgets/HelloWorld/Index.jsx into index.jsx, because the sample was not running on my Linux ("npm run dev")

@pcross616 pcross616 merged commit 0c30f6c into Raathigesh:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants