This repository has been archived by the owner on Jan 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
ReCAPTCHA + Rate Limit Refactor + Deduped Pin Cost Calculation Where Possible #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proper rate limiting results as this will cause gin to skip processing
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 52.88% 52.67% -0.21%
==========================================
Files 43 43
Lines 4342 4371 +29
==========================================
+ Hits 2296 2302 +6
- Misses 1536 1557 +21
- Partials 510 512 +2
Continue to review full report at Codecov.
|
bonedaddy
changed the title
ReCAPTCHA + Rate Limit Refactor
ReCAPTCHA + Rate Limit Refactor (DO NOT MERGE)
Apr 17, 2020
bonedaddy
changed the title
ReCAPTCHA + Rate Limit Refactor (DO NOT MERGE)
ReCAPTCHA + Rate Limit Refactor
Apr 17, 2020
bonedaddy
changed the title
ReCAPTCHA + Rate Limit Refactor
ReCAPTCHA + Rate Limit Refactor + Deduped Pin Cost Calculation Where Possible
Apr 18, 2020
xiegeo
approved these changes
Apr 19, 2020
api/middleware/jwt.go
Outdated
Comment on lines
65
to
68
if usr.EmailEnabled && usr.AccountEnabled { | ||
return true | ||
} | ||
return false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return usr.EmailEnabled && usr.AccountEnabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👷 Purpose
Enabling optional usage of reCAPTCHA v3, and refactor rate limiter, require verified emails to login. The release of this PR needs to be timed on several factors:
Update warp to include the same logicUpdate database to set unverified limits to 0ENS management app updatedThis is the main coordination aspect. We need to time a deploy of our update with a deploy of the ens management appCloses #476
🚀 Changes
None