Skip to content

Conversation

@yuqingli05
Copy link
Contributor

@yuqingli05 yuqingli05 commented Dec 19, 2024

拉取/合并请求描述:(PR description)

[
并确认并列出已经在什么情况或板卡上进行了测试。
And confirm in which case or board has been tested. -->
自己板子

为什么提交这份PR (why to submit this PR)

当定义了RT_USING_DFS_V2但未定义RT_RT_USING_DFS_DEVFS时,编译报错
当定义了RT_USING_DFS_V2但未定义RT-USING_SMART时,会发生错误
fal_rtt.c 缺少头,提醒函数未定义

你的解决方案是什么 (what is your solution)

修改源码

请提供验证的bsp和config (provide the config and bsp)

[
config.txt
]

  • BSP: bsp\stm32\stm32f103-atk-nano
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@yuqingli05
Copy link
Contributor Author

yuqingli05 commented Dec 20, 2024

@myshowtogo 不好意思,42e75469d28f83 不属于这个PR。这是我错误的提交到这个分支导致的。可以忽略,后面我会单独提交PR来讨论这个问题。

@dongly dongly mentioned this pull request Dec 21, 2024
10 tasks
@BernardXiong
Copy link
Member

请都独立来提交PR,并且提交的commit请提供更详细的信息,谢谢

@yuqingli05
Copy link
Contributor Author

yuqingli05 commented Dec 24, 2024

从新在 #9826 提交

@yuqingli05 yuqingli05 deleted the branch RT-Thread:master December 24, 2024 10:57
@yuqingli05 yuqingli05 closed this Dec 24, 2024
@yuqingli05 yuqingli05 deleted the master branch December 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants