Skip to content

Conversation

@CYFS3
Copy link
Contributor

@CYFS3 CYFS3 commented Oct 6, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#9424

你的解决方案是什么 (what is your solution)

Clip_2024-10-07_00-50-40

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@supperthomas
Copy link
Member

建议一次性把想改的都改了

@CYFS3 CYFS3 marked this pull request as draft October 6, 2024 15:32
@CYFS3 CYFS3 changed the title [doxygen][rsoc]add pwm driver example for doxygen [doxygen][rsoc]add pwm、pin、can、i2c driver example for doxygen Oct 6, 2024
@CYFS3 CYFS3 changed the title [doxygen][rsoc]add pwm、pin、can、i2c driver example for doxygen [doxygen][rsoc]add pwm pin can i2c spi driver example for doxygen Oct 6, 2024
@CYFS3 CYFS3 changed the title [doxygen][rsoc]add pwm pin can i2c spi driver example for doxygen [doxygen][rsoc]add pwm touch can i2c spi driver example for doxygen Oct 6, 2024
@CYFS3 CYFS3 marked this pull request as ready for review October 6, 2024 16:59
@supperthomas
Copy link
Member

本地仓库中,可以用action验证下,选择对应的branch

@supperthomas
Copy link
Member

image

@supperthomas
Copy link
Member

非常感谢贡献,
内容可以根据https://www.rt-thread.org/document/api/group__pin.html 这里的中文注释,丰富一些

Copy link
Member

@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请注意一下CI错误提示 返回值有问题

@CYFS3 CYFS3 marked this pull request as draft October 8, 2024 06:17
@CYFS3 CYFS3 marked this pull request as ready for review October 8, 2024 07:23
@CYFS3
Copy link
Contributor Author

CYFS3 commented Oct 8, 2024

请注意一下CI错误提示 返回值有问题

已解决

@CYFS3
Copy link
Contributor Author

CYFS3 commented Oct 8, 2024

非常感谢贡献, 内容可以根据https://www.rt-thread.org/document/api/group__pin.html 这里的中文注释,丰富一些

添加了i2c spi pin 的相关宏定义说明

@mysterywolf mysterywolf merged commit 2b281ff into RT-Thread:master Oct 8, 2024
@CYFS3 CYFS3 deleted the add_doxygen branch October 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants