Skip to content

Conversation

@zx568073531
Copy link
Contributor

拉取/合并请求描述:(PR description)

为什么提交这份PR (why to submit this PR)

audio_pipe中函数在开启POSIX IPC时与 POSIX PIPE冲突问题。在drivers/audio/audio_pipe.c中申明了:

rt_pipe_read
rt_pipe_write
rt_pipe_control

这三个函数,如果在不开启POSIX IPC的情况下可以正常编译过去,但是如果开启 POSIX并打开IPC时,会提示以下错误:

3c2b4c3dd7ccee40d3fef1837f21695

你的解决方案是什么 (what is your solution)

将以下三个函数:

rt_pipe_read
rt_pipe_write
rt_pipe_control

重命名为:

rt_audio_pipe_read
rt_audio_pipe_write
rt_audio_pipe_control

符合下面 rt_audio_pipe_init函数整体规则。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

bsp\at32f437_start

  • .config:

#define RT_USING_POSIX_FS
#define RT_USING_POSIX_POLL
#define RT_USING_POSIX_SELECT
#define RT_USING_POSIX_SOCKET
#define RT_USING_POSIX_DELAY
#define RT_USING_POSIX_CLOCK
#define RT_USING_POSIX_TIMER
#define RT_USING_PTHREADS
#define PTHREAD_NUM_MAX 8
#define RT_USING_POSIX_MESSAGE_SEMAPHORE

#define RT_USING_AUDIO
#define RT_AUDIO_REPLAY_MP_BLOCK_SIZE 3840
#define RT_AUDIO_REPLAY_MP_BLOCK_COUNT 2
#define RT_AUDIO_RECORD_PIPE_SIZE 7680

  • action:

image

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf merged commit 66dd03f into RT-Thread:master Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants