Skip to content

Conversation

@polarvid
Copy link
Contributor

@polarvid polarvid commented Aug 28, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Fixed #9210:

This patch modifies the kernel and libcpu to support the ILP32D model,
where integers, long integers, and pointers are 32-bit. These changes
are crucial for ensuring that the kernel can correctly handle the 64-bit
architectures with this data model, avoiding potential data type
mismatches and ensuring the correct execution of kernel operations.

你的解决方案是什么 (what is your solution)

Changes:

  • Replaced rt_ubase_t and rt_base_t with rt_uintptr_t and
    rt_intptr_t in various files to correctly represent pointer types
    in the ILP32D model.
  • Updated memory management and IPC operations to ensure alignment
    with the 32-bit pointer expectations.

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

- using generic command instead of abs path
- update BSP configurations
- update README
@github-actions github-actions bot added BSP Kernel PR has src relate code Arch: RISC-V BSP related with risc-v libcpu labels Aug 28, 2024
@polarvid polarvid changed the title feat: Using ILP32D ABI on 64 bit arch feat: Using ILP32D ABI on 64-bit arch Aug 28, 2024
@polarvid polarvid marked this pull request as ready for review August 29, 2024 09:52
@polarvid polarvid requested a review from BernardXiong as a code owner August 29, 2024 09:52
@polarvid
Copy link
Contributor Author

cppcheck 看上去是误报:

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: RISC-V BSP related with risc-v BSP Component Kernel PR has src relate code libcpu +1 Agree +1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] PR #9194 存在问题 | Unresolved thread on PR #9194

3 participants