Skip to content

[kernel][mutex] fix bug of thread exit without releasing mutex & add error check log #9337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mysterywolf merged 3 commits into from
Sep 11, 2024
Merged

[kernel][mutex] fix bug of thread exit without releasing mutex & add error check log #9337

mysterywolf merged 3 commits into from
Sep 11, 2024

Conversation

@zmshahaha
Copy link
Contributor

@zmshahaha zmshahaha commented Aug 23, 2024

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

mysterywolf commented Aug 23, 2024

为什么要加no pi

@zmshahaha zmshahaha closed this Aug 23, 2024
@zmshahaha zmshahaha reopened this Aug 23, 2024
@zmshahaha zmshahaha marked this pull request as draft August 23, 2024 03:57
@zmshahaha
Copy link
Contributor Author

zmshahaha commented Aug 23, 2024

为什么要加no pi

优先级继承方式的mutex实现较重(频繁的任务线程优先级调整)，对性能有影响。

@zmshahaha zmshahaha force-pushed the mutex branch 2 times, most recently from 83cafa8 to 1afc335 Compare August 23, 2024 08:37
@zmshahaha zmshahaha marked this pull request as ready for review August 23, 2024 08:37
@zmshahaha zmshahaha changed the title [kernel][mutex]add mutex NO_PI flag and error check log [kernel][mutex] fix bug of thread exit without releasing mutex & add mutex RECURSIVE flag & add error check log Aug 23, 2024
@zmshahaha zmshahaha force-pushed the mutex branch 2 times, most recently from ad54ac6 to 606f828 Compare August 23, 2024 08:40
@zmshahaha zmshahaha closed this Aug 23, 2024
@zmshahaha zmshahaha reopened this Aug 23, 2024
@zmshahaha
Copy link
Contributor Author

zmshahaha commented Aug 23, 2024

没看懂这个ci报错

@zmshahaha zmshahaha marked this pull request as draft August 23, 2024 10:17
@BernardXiong
Copy link
Member

BernardXiong commented Aug 24, 2024

还有包括，当试图去持有mutex，但超时任务恢复的时候，需要对mutex的优先级进行调整的。

@BernardXiong BernardXiong requested a review from polarvid August 25, 2024 01:16
@zmshahaha zmshahaha force-pushed the mutex branch 2 times, most recently from 36cc2de to f7e9e8d Compare August 26, 2024 01:38
@zmshahaha zmshahaha changed the title [kernel][mutex] fix bug of thread exit without releasing mutex & add mutex RECURSIVE flag & add error check log [kernel][mutex] fix bug of thread exit without releasing mutex & add error check log Aug 26, 2024
@zmshahaha zmshahaha marked this pull request as ready for review August 26, 2024 01:39
@Rbb666 Rbb666 added the Kernel PR has src relate code label Aug 26, 2024
polarvid
polarvid suggested changes Aug 28, 2024
View reviewed changes
@zmshahaha
Copy link
Contributor Author

zmshahaha commented Aug 29, 2024

还有包括，当试图去持有mutex，但超时任务恢复的时候，需要对mutex的优先级进行调整的。

这个我测的没有问题，代码上也能看到mutex超时恢复调整优先级的逻辑

This was referenced Sep 4, 2024
Merged
Open
@BernardXiong BernardXiong added the +1 Agree +1 label Sep 7, 2024
@mysterywolf mysterywolf requested a review from polarvid September 9, 2024 22:08
@mysterywolf
Copy link
Member

mysterywolf commented Sep 9, 2024

@polarvid 麻烦再review一下呗

@mysterywolf mysterywolf reopened this Sep 10, 2024
mysterywolf
mysterywolf requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI 有错误

@mysterywolf mysterywolf removed the +1 Agree +1 label Sep 10, 2024
@zmshahaha
Copy link
Contributor Author

zmshahaha commented Sep 10, 2024

感觉是ci有bug

@polarvid
Copy link
Contributor

polarvid commented Sep 10, 2024

感觉是ci有bug

image

ROM 超了

@mysterywolf
Copy link
Member

mysterywolf commented Sep 10, 2024

可以将这个BSP改成-O2编译

@github-actions github-actions bot added the BSP label Sep 11, 2024
@zmshahaha
Copy link
Contributor Author

zmshahaha commented Sep 11, 2024

编译问题修了

@mysterywolf mysterywolf merged commit 08221b5 into RT-Thread:master Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BernardXiong BernardXiong BernardXiong approved these changes

@mysterywolf mysterywolf mysterywolf approved these changes

+1 more reviewer

@polarvid polarvid polarvid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BSP Kernel PR has src relate code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zmshahaha @mysterywolf @BernardXiong @polarvid @Rbb666