Skip to content

Conversation

@rcitach
Copy link
Contributor

@rcitach rcitach commented Aug 15, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

1.使用mmap时,当传入一个非常大的地址时,offset会计算得到一个值,又因为传入的地址错误,rc会得到错误码,结合offset会得到一个很奇怪的值。
2.执行setpgrp后,再使用getpgrp无法得到创建的group的值

你的解决方案是什么 (what is your solution)

1.修改mmap的返回方式
2.添加group = lwp_pgrp_create(process);执行后的一些行为

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

当传入一个非常大的地址时,offset会计算得到一个值,又因为传入的地址错误,rc会得到错误码,结合offset会得到一个很奇怪的值。
执行setpgrp会走到这一步,在执行getpgrp无法得到创建的group的值
@polarvid polarvid added the RT-Smart RT-Thread Smart related PR or issues label Aug 20, 2024
Copy link
Contributor

@polarvid polarvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR message 请补充一下修改说明。

@polarvid polarvid self-requested a review August 20, 2024 10:19
@polarvid polarvid added the +1 Agree +1 label Aug 21, 2024
@mysterywolf mysterywolf merged commit 9a84c13 into RT-Thread:master Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: lwp RT-Smart RT-Thread Smart related PR or issues +1 Agree +1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants