Skip to content

[smart/tty] skip configure of rt_serial on tty open #9152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BernardXiong merged 1 commit into from
Jul 9, 2024
Merged

[smart/tty] skip configure of rt_serial on tty open #9152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions components/drivers/serial/serial_tty.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,16 @@ static int serial_tty_param(struct lwp_tty *tp, struct termios *t)
RT_ASSERT(softc);
serial = softc->parent;

if (!tty_opened(tp))
{
/**
* skip configure on open since all configs are copied from the current
* configuration on device. So we don't bother to set it back to device
* again.
*/
return RT_EOK;
}

cfsetispeed(t, t->__c_ispeed);
return rt_device_control(&(serial->parent), TCSETS, t);
}
Expand Down