[bsp/stm32l496_ali] add the on-chip flash #6061

supperthomas · 2022-06-09T12:36:25Z

拉取/合并请求描述：(PR description)

[bsp/stm32l496_ali] fix the on-chip flash config

以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
本拉取/合并请求代码是高质量的 Code in this PR is of high quality
本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

mysterywolf

Kconfig没有做出对应的修改

bsp/stm32/stm32l496-ali-developer/board/Kconfig

mysterywolf · 2022-06-10T04:18:17Z

这么写不对，C文件没改过来. 注意onchip是一个词

config BSP_USING_ONCHIP_FLASH
select RT_USING_FAL

config BSP_USING_ONCHIP_FLASH_FATFS
bool "Enable onchip flash with FatFS"
depends on BSP_USING_ONCHIP_FLASH
select RT_USING_DFS
select RT_USING_DFS_ELMFAT

mysterywolf · 2022-06-10T04:18:48Z

把这个也改一下吧 #6056

bsp/stm32/stm32l496-ali-developer/board/mnt.c

supperthomas · 2022-06-10T14:10:42Z

这么写不对，C文件没改过来. 注意onchip是一个词

config BSP_USING_ONCHIP_FLASH select RT_USING_FAL

config BSP_USING_ONCHIP_FLASH_FATFS bool "Enable onchip flash with FatFS" depends on BSP_USING_ONCHIP_FLASH select RT_USING_DFS select RT_USING_DFS_ELMFAT

BSP_USING_ON_CHIP_FLASH 这个HAL_Driver里面有用到

bsp/stm32/stm32l496-st-nucleo/board/mnt_onchip.c

mysterywolf · 2022-06-10T15:12:57Z

bsp/stm32/stm32l496-ali-developer/board/mnt.c

+
+#include <rtthread.h>
+#include <rtdevice.h>
+


Suggested change

#define DBG_TAG "mnt"

#define DBG_LVL DBG_INFO

#include <rtdbg.h>

bsp/stm32/stm32l496-ali-developer/board/mnt.c

mysterywolf · 2022-06-10T15:14:25Z

bsp/stm32/stm32l496-ali-developer/board/mnt.c

+    mtd_dev = fal_blk_device_create(FS_PARTITION_NAME);
+    if (!mtd_dev)
+    {
+        rt_kprintf("Failed to create device.\n");


Suggested change

rt_kprintf("Failed to create device.\n");

LOG_E("Failed to create device.");

mysterywolf · 2022-06-10T15:14:42Z

bsp/stm32/stm32l496-st-nucleo/board/mnt_onchip.c

+#ifdef BSP_USING_ON_CHIP_FLASH_FATFS
    if (dfs_mount(FS_PARTITION_NAME, "/", "elm", 0, 0) == 0)
    {
        rt_kprintf("Filesystem initialized!");


Suggested change

rt_kprintf("Filesystem initialized!");

LOG_I("Filesystem initialized!");

mysterywolf · 2022-06-10T15:14:50Z

bsp/stm32/stm32l496-st-nucleo/board/mnt_onchip.c

    mtd_dev = fal_blk_device_create(FS_PARTITION_NAME);
+    if (!mtd_dev)
+    {
+        rt_kprintf("Failed to create device.\n");


Suggested change

rt_kprintf("Failed to create device.\n");

LOG_E("Failed to create device.");

mysterywolf · 2022-06-10T15:15:09Z

bsp/stm32/stm32l496-st-nucleo/board/mnt_onchip.c

        dfs_mkfs("elm", FS_PARTITION_NAME);
        if (dfs_mount(FS_PARTITION_NAME, "/", "elm", 0, 0) != 0)
        {
            rt_kprintf("Failed to initialize filesystem!");


Suggested change

rt_kprintf("Failed to initialize filesystem!");

LOG_E("Failed to initialize filesystem!");

mysterywolf · 2022-06-10T15:16:01Z

bsp/stm32/stm32l496-st-nucleo/board/mnt_onchip.c


 #ifdef RT_USING_DFS
 #include <dfs_fs.h>



Suggested change

#define DBG_TAG "mnt"

#define DBG_LVL DBG_INFO

#include <rtdbg.h>

supperthomas

fix log

Stm32 ali

[bsp/stm32l496_ali] add the on-chip flash

79ce3cf

mysterywolf approved these changes Jun 9, 2022

View reviewed changes

mysterywolf added +1 Agree +1 and removed +1 Agree +1 labels Jun 9, 2022

mysterywolf requested changes Jun 9, 2022

View reviewed changes

[bsp/stm32l496_ali]add Kconfig

54706c8

mysterywolf approved these changes Jun 10, 2022

View reviewed changes

mysterywolf added the +1 Agree +1 label Jun 10, 2022

Guozhanxin reviewed Jun 10, 2022

View reviewed changes

bsp/stm32/stm32l496-ali-developer/board/Kconfig Show resolved Hide resolved

remove the DFS

aaba2c0

mysterywolf added in progress PR/issue in progress. and removed +1 Agree +1 labels Jun 10, 2022

fix Kconfig

e8c6e9f

mysterywolf requested changes Jun 10, 2022

View reviewed changes

bsp/stm32/stm32l496-ali-developer/board/mnt.c Show resolved Hide resolved

supperthomas added 2 commits June 10, 2022 22:05

fix the config

e6830f3

fix the config

b30363c

mysterywolf requested changes Jun 10, 2022

View reviewed changes

bsp/stm32/stm32l496-st-nucleo/board/mnt_onchip.c Outdated Show resolved Hide resolved

fix the define

0017b74

mysterywolf requested changes Jun 10, 2022

View reviewed changes

supperthomas commented Jun 10, 2022

View reviewed changes

supperthomas and others added 4 commits June 11, 2022 06:11

fix log

263ef92

update

d27c285

Merge branch 'RT-Thread:master' into stm32_ali

1d20c69

Merge pull request #4 from mysterywolf/stm32_ali

64690ce

Stm32 ali

mysterywolf approved these changes Jun 10, 2022

View reviewed changes

mysterywolf removed the in progress PR/issue in progress. label Jun 10, 2022

mysterywolf added +1 Agree +1 BSP: STM32 BSP related with ST/STM32 labels Jun 10, 2022

Guozhanxin approved these changes Jun 13, 2022

View reviewed changes

Guozhanxin added the +2 Agree +2 label Jun 13, 2022

Guozhanxin merged commit c16eaf5 into RT-Thread:master Jun 13, 2022

supperthomas deleted the stm32_ali branch September 26, 2022 14:29

+#define DBG_TAG    "mnt"
+#define DBG_LVL    DBG_INFO
+#include <rtdbg.h>

	rt_kprintf("Failed to create device.\n");
	LOG_E("Failed to create device.");

	rt_kprintf("Filesystem initialized!");
	LOG_I("Filesystem initialized!");

	rt_kprintf("Failed to initialize filesystem!");
	LOG_E("Failed to initialize filesystem!");

[bsp/stm32l496_ali] add the on-chip flash #6061

[bsp/stm32l496_ali] add the on-chip flash #6061

Uh oh!

Conversation

supperthomas commented Jun 9, 2022

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

mysterywolf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mysterywolf commented Jun 10, 2022

Uh oh!

mysterywolf commented Jun 10, 2022

Uh oh!

Uh oh!

supperthomas commented Jun 10, 2022

Uh oh!

Uh oh!

mysterywolf Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mysterywolf Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

mysterywolf Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

mysterywolf Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

mysterywolf Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

mysterywolf Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

supperthomas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants