Skip to content

Conversation

@100ask-alen
Copy link
Contributor

@100ask-alen 100ask-alen commented Jun 8, 2022

拉取/合并请求描述:(PR description)

[
重新建立分支,在rtt/bsp/stm32里面的增加了100ask stm32f103开发板的两个bsp:stm32f103_100ask_pro和stm32f103_100ask_mini。
已经在开发板上进行过验证。
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

除了这两点其他没有什么问题

Comment on lines 5 to 17
* @brief : Main program body
******************************************************************************
* @attention
*
* Copyright (c) 2022 STMicroelectronics.
* All rights reserved.
*
* This software is licensed under terms that can be found in the LICENSE file
* in the root directory of this software component.
* If no LICENSE file comes with this software, it is provided AS-IS.
*
******************************************************************************
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个main.c文件请删除掉

}

INIT_COMPONENT_EXPORT(rt_hw_user_key_init);
#endif No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行再按个回车键

@mysterywolf
Copy link
Member

请接着提交commits就可以 不需要关闭pr重新提交

@100ask-alen
Copy link
Contributor Author

现在是在什么地方出问题了呢,没有看明白

@mysterywolf mysterywolf added +2 Agree +2 +1 Agree +1 labels Jun 8, 2022
@mysterywolf
Copy link
Member

现在是在什么地方出问题了呢,没有看明白

https://github.com/mysterywolf/formatting 下回可以用这个扫描一下

@BernardXiong BernardXiong merged commit 4fa1beb into RT-Thread:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+1 Agree +1 +2 Agree +2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants