-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[bsp][100ask]: create two new bsp for 100ask stm32f103 boards and commit them #6045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mysterywolf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
除了这两点其他没有什么问题
| * @brief : Main program body | ||
| ****************************************************************************** | ||
| * @attention | ||
| * | ||
| * Copyright (c) 2022 STMicroelectronics. | ||
| * All rights reserved. | ||
| * | ||
| * This software is licensed under terms that can be found in the LICENSE file | ||
| * in the root directory of this software component. | ||
| * If no LICENSE file comes with this software, it is provided AS-IS. | ||
| * | ||
| ****************************************************************************** | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个main.c文件请删除掉
| } | ||
|
|
||
| INIT_COMPONENT_EXPORT(rt_hw_user_key_init); | ||
| #endif No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行再按个回车键
|
请接着提交commits就可以 不需要关闭pr重新提交 |
…he file named user_key.c
…/bsp/stm32/stm32f103_100ask_mini
|
现在是在什么地方出问题了呢,没有看明白 |
https://github.com/mysterywolf/formatting 下回可以用这个扫描一下 |
拉取/合并请求描述:(PR description)
[
重新建立分支,在rtt/bsp/stm32里面的增加了100ask stm32f103开发板的两个bsp:stm32f103_100ask_pro和stm32f103_100ask_mini。
已经在开发板上进行过验证。
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up