Skip to content

Conversation

@kaidegit
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

整理了下
#9998

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added action github action yml imporve tools labels Feb 22, 2025
@BernardXiong
Copy link
Member

这个加速了多少?

@kaidegit
Copy link
Contributor Author

这个加速了多少?

14min->10min这样吧

#9998 (comment)

@supperthomas
Copy link
Member

esp32c3可以cmake吗?

@kaidegit
Copy link
Contributor Author

ci过不去,我本地scons都跑不过去🤦‍♂️

说实话,我觉得没什么人会用rtt+esp32。。。

@supperthomas
Copy link
Member

ci过不去,我本地scons都跑不过去🤦‍♂️

说实话,我觉得没什么人会用rtt+esp32。。。

后面可以看看能不能把bsp的sdk软件包放到其他非package的文件夹

@kaidegit
Copy link
Contributor Author

kaidegit commented Feb 24, 2025

info = utils.ProjectInfo(env)

这句话蛮耗时,但倒腾出了个env就有的玩意🤦‍♂️

image

@supperthomas supperthomas added the +1 Agree +1 label Feb 24, 2025

return success

def build_bsp_cmake(bsp, scons_args=''):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog license 加一下

@supperthomas
Copy link
Member

rebase一下看看

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve tools +1 Agree +1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants