This repository has been archived by the owner on May 12, 2022. It is now read-only.
【优化】读写接口溢出问题 #31
Open
【优化】读写接口溢出问题 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@Guozhanxin 请安排人确认一下这个问题 |
Guozhanxin
approved these changes
Aug 9, 2021
armink
reviewed
Aug 9, 2021
| @@ -411,7 +411,7 @@ int fal_partition_read(const struct fal_partition *part, uint32_t addr, uint8_t | |||
| assert(part); | |||
| assert(buf); | |||
|
|
|||
| if (addr + size > part->len) | |||
| if (addr >= part->len || part->len - addr < size) | |||
There was a problem hiding this comment.
Suggested change
| if (addr >= part->len || part->len - addr < size) | |
| if (addr >= part->len || addr + size > part->len) |
改成这种方式吧，上面那个感觉逻辑不太直观
There was a problem hiding this comment.
他的意思是 addr+size 有可能会溢出吧，所以改成了减
There was a problem hiding this comment.
其实只有当，fal 管理的地址空间达到 4G 的时候，才会出现这个问题。
|
@cproape 兄弟，你的flash大小是多大的啊，怎么会溢出的呢😂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.