Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for pointer cursor #517

Merged
merged 6 commits into from
Sep 21, 2024
Merged

feat: add support for pointer cursor #517

merged 6 commits into from
Sep 21, 2024

Conversation

yuzhang9804
Copy link
Contributor

Description

  • Add support for cursor pointer

image

Copy link

vercel bot commented Sep 19, 2024

@yuzhang9804 is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 5:38am

@Innei
Copy link
Member

Innei commented Sep 20, 2024

Even though I don't have this option turned on, the pointer to Switch is cursor.

@yuzhang9804
Copy link
Contributor Author

  • The dependencies for useEffect haven't been added.
  • The cursor now has multiple CSS variables. Should this be adjusted? If there's no need for atomization, I feel one CSS variable might suffice.

@jerryc127
Copy link
Contributor

這種不是應該强制開啓的麽,不需要提供設置。
follow 現在很多可交互的item, 即沒有Hover 效果,也沒有 pointer cursor
很難察覺這是可以點擊的


This should be enabled by default and shouldn't require configuration. There are many interactive items in Follow, but they lack both hover effects and a pointer cursor, making it hard to tell that they are clickable.

@yuzhang9804
Copy link
Contributor Author

I've sent a direct message to Innei about this. The default cursor being set to 'default' is intended to make the application feel more like a native app.

@Innei
Copy link
Member

Innei commented Sep 20, 2024

#442

@Innei Innei added the ux Doesn't affect functionality, but affects user interaction label Sep 20, 2024
@yuzhang9804
Copy link
Contributor Author

If there are plans to address this issue, should I close this PR for now?

@yuzhang9804 yuzhang9804 reopened this Sep 21, 2024
@Innei Innei merged commit b6ff6fb into RSSNext:dev Sep 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux Doesn't affect functionality, but affects user interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants