fix: EntryListHeader' margin in Pictures View #1106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cuikaipeng is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: #1103
There are still some questions here
When there is no
TimelineTabscomponent, there are some margin issues in thePictures PageIn my previous PR #1054, I added
mb-2 stylewhen there is not theArticles PageandPictures Pagebecause these two pages haveTimelineTabscomponent. At that time, there are some issues with my modifications, I did not consider the situation whereTimelineTabscomponent were not available (this component would not display when user do not have lists and inbox data)So my idea is control whether
mb-2 styleis required by determining whether theTimelineTabscomponent is nullSo I submitted this PR.
Linked Issues
Additional context