[JsonFormat] implemented JSON Feed version 1 format #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thanks for the PR, great work! 🥇
Yes, that is a good idea. So long as we don't need to pull data from external sources, we should test the API as much as possible. |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
JsonFormat now implements https://jsonfeed.org/version/1 Closes RSS-Bridge#618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since JsonFormat was just a JSON representation of the feed items without a proper use, I rewrote it to comply with the JSON Feed specs (https://jsonfeed.org/version/1). Since JSON Feed allows vendor extensions, any custom item properties that aren't used in the feed appear in the "_rssbride" object (starting with a _ character as required by the specs).
The feed samples for JsonFormatTest may be useful for other format tests as well, so we could write similar unit tests for Atom and (M)RSS.
This PR addresses issue #618.