-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use file_get_contents when in CLI mode & no certs #962
Conversation
Use file_get_contents when in CLI mode with no root certificates for cUrl. file_get_contents can naively use system root certificates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Find below a few comments to make the code more consistent with the remaining file. These changes shouldn't affect the functional behavior, but maybe you can test it anyway?
I've implemented the suggested changes and everything still works. |
It would probably be neater if I put all the cUrl stuff in a conditional statement. Would this be ok? |
Thanks for the updates! You are right, separating implementation makes sense. The function has become very large, so it needs refactoring in the future, but we'll leave that for another time. Merging now... |
…dge#962) file_get_contents can natively use system root certificates, so use file_get_contents when in CLI mode with no root certificates for cURL.
Use file_get_contents when in CLI mode with no root certificates for cUrl. file_get_contents can natively use system root certificates.
Relates to #954