Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MozillaBugTrackerBridge] New Bridge #916

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

AntoineTurmel
Copy link
Contributor

@AntoineTurmel AntoineTurmel commented Nov 8, 2018

This Bridge is a clone of KernelBugTrackerBridge (thanks to @logmanoriginal) but for Mozilla Bugzilla. There is some difference in the class used to get the right comments.

BTW there is a bug opened in Bugzilla to support RSS feed ^^ see: https://bugzilla.mozilla.org/256718

This Bridge is a clone of KernelBugTrackerBridge but for Mozilla Bugzilla. There is some difference in the class used to get the right comments.
@logmanoriginal
Copy link
Contributor

Thanks for the PR!

From what I can tell the differences between bugzilla.kernel.org and bugzilla.mozilla.org are very little, only favicon and some classes on line 69. I think it makes sense to merge them into one BugzillaBridge, right?

Especially because there are lots of sites using it: https://www.bugzilla.org/installation-list/

@AntoineTurmel
Copy link
Contributor Author

Yeah I was thinking of doing a generic Bugzilla bridge, but there can be some changes in some installations... maybe we can do a Switch inside the bridge to handle specific installations ? I'll see if I can make more Bugzilla instances to work.

@logmanoriginal
Copy link
Contributor

I did something similar in the XenForo bridge, where different versions are detected based on certain classes found in the DOM. Not the best solution, but unless the version is explicitly included in the DOM this is one way to go. I randomly used VERSION_1 and VERSION_2 for whatever class I found first 🤷‍♂️

bugzilla.mozilla.org fortunately has the generator tag included in the header. It indicates the specific version used (currently Bugzilla 20181106.1).

bugzilla.kernel.org unfortunately doesn't 🤦‍♂️

One way is to check if the version is specified and act on it. For trackers without explicit versions we can just search for some class and assign random versions. Of course, if the generator has an unknown version, we got a nice way to notify users to report it, so we can add the new version.

@logmanoriginal logmanoriginal merged commit 3212156 into RSS-Bridge:master Mar 23, 2019
@logmanoriginal
Copy link
Contributor

Merged. We can combine bridges at a later time, when it becomes a bigger concern. For now it I think this works fine.

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
This Bridge is a clone of KernelBugTrackerBridge but for Mozilla Bugzilla. There is some difference in the class used to get the right comments.
@yamanq yamanq mentioned this pull request May 12, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants