Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GiteaBridge] Rewrite to decouple from Gogs and add contexts #2718

Merged
merged 9 commits into from
May 12, 2022

Conversation

gileri
Copy link
Contributor

@gileri gileri commented May 10, 2022

Continuation of #2670.

This PR makes separates GiteaBridge from GogsBridge, and make it compatible with Gitea 1.0 and 1.17 (at least).
If a compatibility issue on a version between those two, I'd be happy to fix it.

It also implements the Tags, Pull Request, and Single pull request bridge context.

@github-actions
Copy link

github-actions bot commented May 10, 2022

Pull request artifacts

file last change
Gitea-current-context1 2022-05-11, 21:52:04
Gitea-current-context2 2022-05-11, 21:52:04
Gitea-current-context3 2022-05-11, 21:52:04
Gitea-current-context4 2022-05-11, 21:52:04
Gitea-pr-context1 2022-05-11, 21:52:04
Gitea-pr-context2 2022-05-11, 21:52:04
Gitea-pr-context3 2022-05-11, 21:52:04
Gitea-pr-context4 2022-05-11, 21:52:04
Gitea-pr-context5 2022-05-11, 21:52:04
Gitea-pr-context6 2022-05-11, 21:52:04
Gitea-pr-context7 2022-05-11, 21:52:04

@Bockiii
Copy link
Contributor

Bockiii commented May 11, 2022

Great work, thanks!

Right now, the example values dont produce anything since there is not gitea/gitea on the tryout instance. There is the prepared repo on https://gitea.com/gitea/gitea but that's empty so it wont generate anything for most of the contexts. You should be able to use their helm charts repo though, it has issues, PRs, tags, releases etc:
https://gitea.com/gitea/helm-chart

Can you adapt the examplevalues pls?

@gileri
Copy link
Contributor Author

gileri commented May 11, 2022

Good idea @Bockiii !

I've replaced the exampleValues, and made a couple of fixes.

@Bockiii
Copy link
Contributor

Bockiii commented May 11, 2022

There are a few debug notices for the single issue and single pr contexts, can you check if you can get rid of those? other than that, it looks fine to me.

Just one consistency note: You switch between " - text" and "text - " (for example: "helm-chart Releases" and "Tags for helm-chart". Maybe set those up consistently, but it's not super important.

@gileri
Copy link
Contributor Author

gileri commented May 11, 2022

Good catch, fixed both.

Regarding the notices, it's about code reviews (an example), which are a bit finicky. For now the bridge will only handle comments in code reviews, and not the whole code-review block.

I think the titles are a bit better now :

@Bockiii
Copy link
Contributor

Bockiii commented May 12, 2022

Alright, looks good to me. Thx

@Bockiii Bockiii merged commit e01f0bc into RSS-Bridge:master May 12, 2022
Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants